[Timelion, Vega, TSVB] Migrate to dataViews service #128127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
added
Feature:Timelion
stratoula
changed the title
stratoula
added
technical debt
5 tasks
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
mbondyra
reviewed
Mar 21, 2022
| @@ -6,12 +6,13 @@ | |||
| * Side Public License, v 1. | |||
| */ | |||
|
|
|||
| import type { IndexPatternsContract, ISearchStart } from 'src/plugins/data/public'; | |||
| import type { ISearchStart } from 'src/plugins/data/public'; | |||
| import type { DataViewsContract } from 'src/plugins/data_views/public'; | |||
| import type { ChartsPluginStart } from 'src/plugins/charts/public'; | |||
| import { createGetterSetter } from '../../../../kibana_utils/public'; | |||
|
|
|||
| export const [getIndexPatterns, setIndexPatterns] = | |||
There was a problem hiding this comment.
I hope we'll address these namings at some point too, but I understand it would be hard to manage in one PR 👌🏼
There was a problem hiding this comment.
Yes this is not the scope of this PR :)
mbondyra
approved these changes
Mar 21, 2022
alexwizp
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #124086
This PR is handling Timelion, Vega and TSVB. I have updated the dataviews relates types and methods to use the ones from the data_views plugin.
Checklist