Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Migrate to dataViews service #128131

Merged
merged 2 commits into from
Mar 21, 2022
Merged

[Visualize] Migrate to dataViews service #128131

merged 2 commits into from
Mar 21, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Mar 21, 2022 •
edited
Loading

Summary

Part of #124086
This PR is handling the Visualize editor case. I have updated all deprecated types and methods to import from the data_views plugin.

Checklist

@stratoula stratoula changed the title [Visualize] DataViews service [Visualize] Migrate to dataViews service Mar 21, 2022
@stratoula stratoula mentioned this pull request Mar 21, 2022
Closed
5 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 164.3KB 164.3KB -16.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 45.6KB 45.7KB +135.0B
Unknown metric groups

References to deprecated APIs

id before after diff
visualizations 111 14 -97

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.2.0 labels Mar 21, 2022
@stratoula stratoula marked this pull request as ready for review March 21, 2022 12:03
@stratoula stratoula requested a review from a team as a code owner March 21, 2022 12:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula stratoula added the technical debt Improvement of the software architecture and operational architecture label Mar 21, 2022
mbondyra
mbondyra approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! I didn't test but I think it's not needed if the functional tests are working. 👌🏼

@stratoula stratoula merged commit ce0710e into elastic:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stratoula @kibana-ci @elasticmachine @mbondyra