A11y tests for saved objects management table

[bhavyarm]

Meta: #51456

A11y tests for saved objects table

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: 5e28fba
• Interpreting CI Failures
• Storybooks Preview
• Webpack Bundle Analyzer

Failed CI Steps

• FTR Configs #42
• FTR Configs #42

Test Failures

• [job] [logs] FTR Configs #42 / Kibana saved objects management page a11y tests share to space panel from actions meets a11y requirements
• [job] [logs] FTR Configs #42 / Kibana saved objects management page a11y tests share to space panel from actions meets a11y requirements

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
savedObjectsManagement	83.7KB	83.8KB	+36.0B

History

• 💔 Build #50607 failed 50debff
• 💔 Build #35365 failed 0540330
• 💔 Build #33266 failed 96ffa9d
• 💔 Build #33207 failed dcad209

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[bhavyarm]

So this test keeps failing because I cannot click on the action menu here.

A bunch of QA folks tried to help and Spencer. At this point - we are wondering if the implementation of the table is the problem.

Thanks,
Bhavya

It either fails on share to spaces test or on copy to spaces test.

it('share to space panel from actions meets a11y requirements ', async () => {
      await testSubjects.click('euiFlyoutCloseButton');

      await testSubjects.click('euiCollapsedItemActionsButton');
      await find.byCssSelector('.euiContextMenuPanel');
      await testSubjects.click('savedObjectsTableAction-share_saved_objects_to_space');
      await retry.try(async () => {
        await a11y.testAppSnapshot();
      });
      // creating a new space from this panel
      await testSubjects.click('sts-new-space-link');
      await PageObjects.spaceSelector.clickEnterSpaceName();
      await PageObjects.spaceSelector.addSpaceName('space_a');
      await PageObjects.spaceSelector.clickSaveSpaceCreation();
      await PageObjects.settings.navigateTo();
      await PageObjects.settings.clickKibanaSavedObjects();
      await (await find.byCssSelector('[title="Type"]')).click();
      await (await find.byCssSelector('[title="data view"]')).click();
      await browser.pressKeys(browser.keys.ESCAPE);
      await find.byCssSelector('.euiContextMenuPanel');
      await retry.waitFor(
        'actions button visible',
        async () => await testSubjects.exists('euiCollapsedItemActionsButton')
      );
      await testSubjects.click('euiCollapsedItemActionsButton');
      await testSubjects.click('savedObjectsTableAction-share_saved_objects_to_space');
      await (await find.byCssSelector('[title="All spaces"]')).click();
      await testSubjects.click('sts-save-button');
      await retry.waitFor('toasts.toBeVisible', async () => (await toasts.getToastCount()) > 0);
      await toasts.dismissAllToasts();
    });

    it('copy to space panel from actions menu meets a11y requirements ', async () => {
      await find.byCssSelector('.euiContextMenuPanel');
      await retry.waitFor(
        'actions button visible',
        async () => await testSubjects.exists('euiCollapsedItemActionsButton')
      );
      await testSubjects.click('euiCollapsedItemActionsButton');
      await PageObjects.common.sleep(1000);
      await find.byCssSelector('.euiContextMenuPanel');
      await testSubjects.click('euiCollapsedItemActionsButton');
      await testSubjects.click('savedObjectsTableAction-copy_saved_objects_to_space');
      await a11y.testAppSnapshot();
    });

 info Saving page source to: /Users/bhavyarajumandya/Desktop/kibana_dev/kibana/x-pack/test/functional/failure_debug/html/Kibana saved objects management page a11y tests inspect action from actions menu-3e7857b66d7823875bec1e92966f11e7ee8b657c046abfd4b1bda1d7f83cd516.html
     └- ✖ fail: Kibana saved objects management page a11y tests inspect action from actions menu meets a11y requirements
     │      Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="cts-cancel-button"])
     │ Wait timed out after 10021ms
     │     at /Users/bhavyarajumandya/Desktop/kibana_dev/kibana/node_modules/selenium-webdriver/lib/webdriver.js:901:17
     │     at runMicrotasks (<anonymous>)
     │     at processTicksAndRejections (node:internal/process/task_queues:96:5)
     │       at onFailure (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/common/services/retry/retry_for_success.ts:17:9)
     │       at retryForSuccess (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/common/services/retry/retry_for_success.ts:59:13)
     │       at RetryService.try (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/common/services/retry/retry.ts:31:12)
     │       at Proxy.clickByCssSelector (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/functional/services/common/find.ts:368:5)
     │       at TestSubjects.click (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/test/functional/services/common/test_subjects.ts:104:5)
     │       at Context.<anonymous> (test/accessibility/apps/saved_objects.ts:139:7)
     │       at Object.apply (/Users/bhavyarajumandya/Desktop/kibana_dev/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
     │ 
     │ 

[bhavyarm]

cc @jportner @1Copenut help please? Thanks!

[jportner]

Bhavya, you're describing a problem with the "Copy to space" test. CI, on the other hand, is describing a problem with the "Share to space" test.

I tried to pull this down and it failed on the "Relationships" test, then "Share to space" and "Copy to space" after that:

It looks like the root cause of that problem is that it's not closing the Type filter panel, so it can't click the Actions (...) button, therefore the Actions panel is not displayed and there is no Relationships button on the page.
But overall this is different results than what you're getting.

I'm not sure how to help here.

[bhavyarm]

@jportner thank you. Yeah it either fails in copy to space or share to space. Tried different things to close type filter panel and move the focus away. Still fails.

[jportner]

You might want to try using the SavedObjectsPageObject helper class:

https://github.com/elastic/kibana/blob/main/test/functional/page_objects/management/saved_objects_page.ts

It has helper functions to interact with relationships and copy to space using the object title, which would be less brittle than your current test (that assumes only one data view is displayed in the table)

[bhavyarm]

@jportner thanks. Will try it again. I remember running into an issue with a11y test design and the page objects. Will keep you posted. Thanks!

[jportner]

Just tying up loose ends -- if you need another review in the future please tag @elastic/kibana-security, thanks!