Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KQL] Define KqlContext type #135273

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

lukasolson
Copy link
Member

Summary

When processing KQL DSL into ES query DSL, we make use of a helper object, context. This was introduced when we added support for nested fields, but was never correctly typed. This PR simply introduces the correct type for this object.

Checklist

For maintainers

@lukasolson lukasolson added Feature:KQL KQL Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jun 27, 2022
@lukasolson lukasolson self-assigned this Jun 27, 2022
@lukasolson lukasolson requested a review from a team as a code owner June 27, 2022 22:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/es-query 11 12 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

@lukasolson lukasolson merged commit c477a90 into elastic:main Jun 28, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:KQL KQL release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants