[Fleet] Fix xpack.agents.* to not be editable in UI if defined in kibana.yml #135669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in UI and in sync with config file
nchaulet
added
Team:Fleet
nchaulet
changed the title
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
added
the
release_note:skip
nchaulet
added
release_note:breaking
and removed
release_note:skip
juliaElastic
reviewed
Jul 6, 2022
| content={ | ||
| <FormattedMessage | ||
| id="xpack.fleet.settings.fleetServerHostsPreconfiguredTooltipContent" | ||
| defaultMessage="Fleet Server hosts are configured outside of Fleet. Refer to your kibana config for more detail" |
There was a problem hiding this comment.
nit:more detail-> more details.
…igure-es-fleet-server-hosts
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: cc @nchaulet |
|
@nchaulet will there be any backported versions added for this issue, or a documented workaround for folks not able to upgrade to 8.4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #105400
That PR change the behavior of the
xpack.agents.*(fleet server hosts and elasticsearch hosts) to allow user to update these value from kibana config.If these fields are set in Kibana config it will not be possible to update these settings in the UI.
For this I introduced a new property
preconfigured_fieldsin the settings for fleet server hosts and for elasticsearch hosts, the output will be treated as a preconfigured output.Release notes
If a user set
xpack.fleet.agents.fleet_server.hostsandxpack.fleet.agents.elasticsearch.hostsfields in Kibana config these fields will not be updatable from the Fleet UI but only from the Kibana config file.UI Change
Fleet server hosts
Elasticsearch hosts
How to test?
You can tests that by adding these entries to your kibana config file it creates preconfigured output and settings that you cannot edit from the UI and if you remove these fields from the config they become editable