highlighting for scripted metric agg scripts

[jpcarey]

Adding detection for scripted metric aggregations

POST ledger/_search?size=0
{
    "query" : {
        "match_all" : {}
    },
    "aggs": {
        "profit": {
            "scripted_metric": {
                "init_script" : "params._agg.transactions = []",
                "map_script" : "params._agg.transactions.add(doc.type.value == 'sale' ? doc.amount.value : -1 * doc.amount.value)", 
                "combine_script" : "double profit = 0; for (t in params._agg.transactions) { profit += t } return profit",
                "reduce_script" : "double profit = 0; for (a in params._aggs) { profit += a } return profit"
            }
        }
    }
}

[bleskes]

LGTM. My suggestion would be to just match "([^"]*_)?script" which will be future proof.

[jpcarey]

@bleskes if we expect all fields will be something_script, then I'll change to your suggestion.

[bleskes]

I think we can expect that, yeah - though you know, the world isn't perfect. I think we'll catch more things this way and we can always fix when we run into a problem

[jbudz]

CI failures look legitimate, taking a look.

[jbudz]

Not matching?

[jbudz]

Ace is parsing by array index so we had to add a non capture group. Reopened at #15377.