[Archive Migrations] reporting-ecommerce_kibana_spaces - using an api in conjuction with migration #136288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
test_xpack_functional
release_note:skip
wayneseymour
force-pushed
the
migrations/x-pack-reporting-ecommerce_kibana_spaces
branch
from
6ed31da to
20de036
Compare
wayneseymour
force-pushed
the
migrations/x-pack-reporting-ecommerce_kibana_spaces
branch
from
a1a7ea6 to
9b89532
Compare
LeeDr
reviewed
Jul 22, 2022
x-pack/test/reporting_api_integration/reporting_and_security/validation.ts
Show resolved
Hide resolved
wayneseymour
force-pushed
the
migrations/x-pack-reporting-ecommerce_kibana_spaces
branch
from
9b89532 to
2cdb6fe
Compare
wayneseymour
force-pushed
the
migrations/x-pack-reporting-ecommerce_kibana_spaces
branch
2 times, most recently
from
05ed00d to
f044b0e
Compare
LeeDr
reviewed
Jul 26, 2022
LeeDr
suggested changes
Jul 26, 2022
x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts
Outdated
Show resolved
Hide resolved
wayneseymour
force-pushed
the
migrations/x-pack-reporting-ecommerce_kibana_spaces
branch
2 times, most recently
from
dfece0a to
03d8919
Compare
Replaces the old es archive with kbn archive. Change test to use new archive. Helps with: elastic#102552
how these tests run on cloud and often take longer.
with T Sullivan and Lee.
LeeDr
reviewed
Jul 27, 2022
| @@ -0,0 +1,50 @@ | |||
| { | |||
There was a problem hiding this comment.
I think you want to remove this as it's not being used
LeeDr
suggested changes
Jul 27, 2022
x-pack/test/reporting_api_integration/reporting_and_security/spaces.ts
Outdated
Show resolved
Hide resolved
wayneseymour
force-pushed
the
migrations/x-pack-reporting-ecommerce_kibana_spaces
branch
from
03d8919 to
9730b4e
Compare
wayneseymour
changed the title
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
LeeDr
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change test to use new archive, drop the old one.
This is one of those migrations where even though a
saved object type is not supported in await kibanaServer.savedObjects.cleanStandardList();,
we can still migrate it because an api exists that we can use.
In this case, the spaces api.
Helps with: #102552