Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] [Fleet] Fix missing package-level vars in GCP policy editor (#132068) #136289

Merged
merged 5 commits into from
Jul 14, 2022

Conversation

kpollich
Copy link
Member

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

…132068)

* Fix missing package-level vars in GCP policy editor

Display package-level variables even if they aren't defined on the
existing package policy during an upgrade, honoring default values for
all variables if they exist.

Fixes elastic#131251

* Fix not persisting default values for new variables

* Fix tests

* Address PR feedback + update tests

(cherry picked from commit 5fff510)

# Conflicts:
#	x-pack/plugins/fleet/common/services/validate_package_policy.test.ts
#	x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/step_define_package_policy.test.tsx
@kpollich kpollich enabled auto-merge (squash) July 13, 2022 13:50
@kpollich
Copy link
Member Author

@elasticmachine merge upstream

@kpollich
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 628.8KB 628.9KB +108.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 108.3KB 108.3KB +8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpollich kpollich merged commit bbb1021 into elastic:7.17 Jul 14, 2022
@kpollich kpollich deleted the backport/7.17/pr-132068 branch July 14, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants