-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Add value count #136385
[Lens] Add value count #136385
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this works great!
One question: Does it make sense to change the label from Value count of field
to Count of field values
or something like that. I find this value count of
difficult to understand but it can only be me!
Good suggestion @stratoula , I added it to our next sync to discuss - no strong opinion from my side |
For the definition, can we change this to:
|
Thanks @KOTungseth , adjusted |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Canvas Sharable Runtime
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new value_count
agg lgtm 👍
Fixes #74910
By adding value count to the existing count function in Lens (picking another field than records).
AggConfig changes
Add value count as any other aggconfig type
Lens changes
If the count function is picked, it's auto-picking the records field if there is no other field available (otherwise the user would be forced to make a pick). If coming from another field based function like average, it is keeping the selected field. On the formula, no field means record field - required to adjust some bits as they used to differentiate between field and no field, now the same branches differentiate between field and optional field.