Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lens adhoc dataviews #138482

Closed
wants to merge 31 commits into from
Closed

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 10, 2022

Summary

Implements the ad-hoc dataviews in Lens.

Missing:

  • Merge with main when Marco's PR is merged
  • Open in Discover
  • Discover to Visualize
  • Add a runtime field case
  • Tests (unit and functional tests)

lens1

Checklist

@@ -1,93 +0,0 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
Copy link
Contributor Author

@stratoula stratoula Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I am deleting this file because it is not used anymore in Lens. This must be a leftover from the phase 1 (or from a merge conflict). I can create a separate PR for the removal but as I am dealing here with the dataview picker lists I think I can also remove it here :)

@stratoula
Copy link
Contributor Author

Closing in favor of #138732

@stratoula stratoula closed this Aug 12, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 12, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #5 / apis Lens existing_fields apis legacy existence should find which fields exist in the sample documents
  • [job] [logs] FTR Configs #5 / apis Lens existing_fields apis legacy existence should find which fields exist in the sample documents
  • [job] [logs] Jest Tests #2 / Initializing the store loadInitial does not load documents on sequential renders unless the id changes
  • [job] [logs] Jest Tests #2 / Initializing the store loadInitial loads a document and uses query and filters if initial input is provided
  • [job] [logs] Jest Tests #2 / Initializing the store should initialize initial datasource

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 535 538 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.2MB 1.2MB +2.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 429.0KB 429.1KB +12.0B
lens 34.6KB 34.7KB +50.0B
unifiedSearch 46.8KB 46.9KB +140.0B
total +202.0B
Unknown metric groups

API count

id before after diff
lens 621 624 +3
unifiedSearch 108 109 +1
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants