[Stack Monitoring] Add log-* index pattern support on SM UI #139121
Conversation
There was a problem hiding this comment.
I had a couple code-level thoughts but mostly looks pretty good.
The test steps were pretty involved, but I was able to get some logs to show up.
If anyone else tries, be careful about which kibana. At first I thought it didn't work but I was on the elastic-package kibana (5601) not the PR kibana (5602).
| // 'data_stream.type' will always be 'logs' for `logs-*` indices. | ||
| should: [ | ||
| { term: { 'service.type': 'elasticsearch' } }, | ||
| { term: { 'data_stream.type': 'logs' } }, |
There was a problem hiding this comment.
The logic here has me a little concerned that this might break for standalone filebeat.
Should we maybe have a test that loads in es-archives for both filebeat-* and logs-* to ensure either can work (or even both to account for a transitional case?).
There was a problem hiding this comment.
Agreed, we've initially discussed that but ended up making sure service.type exists in datastreams as well. see elastic/integrations#4033 (comment)
| const indexPatterns = getNewIndexPatterns({ | ||
| type, | ||
| config: getConfigWithCcs(true), | ||
| moduleType: 'elasticsearch', |
There was a problem hiding this comment.
I kind of wanted to put moduleType in the TestTuple, but I can see the ecsLegacyOnly: true. That got me wondering what ecsLegacyOnly: true/false is even really for, but that's beyond the scope of this PR I think.
|
@elasticmachine merge upstream |
klacabane
added
release_note:enhancement
v8.5.0
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
| config: getConfigWithCcs(false), | ||
| moduleType: 'elasticsearch', | ||
| }); | ||
| expect(indexPatterns).toBe(expected); |
There was a problem hiding this comment.
The repetition in these test cases still makes me twitch a little, but maybe best left for future enhancement.
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…139121) * Add log-* index pattern support on SM UI * logs query fix * remove datastream dedicated filter * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * remove comment * renaming filebeat leftovers to logs * extract elasticsearch logs filter * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * update filter * typo Co-authored-by: klacabane <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Summary
This PR adds
logs-*index pattern support on places in the SM UI where it queriesfilebeat-*modules, in order to also work with integration packagescloses #120416
Screenshots
Cluster Overview UI
Elasticsearch overview
Indices view
Testing
Make sure you have elastic-package installed.