Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix error rendering policy editor #141705

Merged
merged 3 commits into from
Sep 26, 2022
Merged

[Fleet] Fix error rendering policy editor #141705

merged 3 commits into from
Sep 26, 2022

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Sep 23, 2022 •
edited by kibanamachine
Loading

Summary

Fixes an error when rendering the "edit policy" screen.

cc @dominiqueclarke @hop-dev

Think this fix actually breaks our upgrade support for non-input packages -> input packages, but it will unblock everything else so I'd like to ship it.

image

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Sep 23, 2022
@kpollich kpollich requested a review from a team as a code owner September 23, 2022 19:19
@kpollich kpollich self-assigned this Sep 23, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich
Copy link
Member Author

@elasticmachine merge upstream

@kpollich kpollich mentioned this pull request Sep 23, 2022
Closed
4 tasks
nchaulet
nchaulet approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me but I am curious to get a little more context on what was failing and what the skipArchive flag is doing here?

@kpollich
Copy link
Member Author

Looks okay to me but I am curious to get a little more context on what was failing and what the skipArchive flag is doing here?

The skipArchive flag basically controls whether or not a package will be loaded into our archive cache as I understand it. I'm going to take a deeper look at @hop-dev's work while he's out

This flag apparently interacts poorly with input packages for reasons I don't quite understand yet. See Mark's comment here: #141671 (comment)

I'm hoping to land this PR then continue working on #137751 this week to track down any issues with upgrades from non-input -> input packages that are related to this skipArchive flag.

@kpollich
Copy link
Member Author

@elasticmachine merge upstream

@kpollich kpollich enabled auto-merge (squash) September 26, 2022 16:35
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 5d48265 into elastic:main Sep 26, 2022
@kibanamachine kibanamachine mentioned this pull request Sep 26, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 26, 2022
@kpollich
Fix error rendering policy editor (elastic#141705)
aaac1db 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 5d48265)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 26, 2022
@kibanamachine @kpollich
Fix error rendering policy editor (#141705) (#141827)
3fb2192 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 5d48265)

Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@kpollich kpollich

Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kpollich @elasticmachine @kibana-ci @kibanamachine @nchaulet