-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fix bugs w/ synthetic source toggle #143097
[Fleet] Fix bugs w/ synthetic source toggle #143097
Conversation
Pinging @elastic/fleet (Team:Fleet) |
<Fragment> | ||
<EuiFlexItem> | ||
<EuiFlexGroup justifyContent="spaceBetween" alignItems="center"> | ||
{/* Advanced section - always shown since we display experimental indexing settings here */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the diff here is whitespace only, so recommend viewing with GitHub's "ignore whitespace" option
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kpollich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import reformatting in x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/feature_table.tsx
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix bugs w/ synthetic source toggle * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 5c3e256)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* Fix bugs w/ synthetic source toggle * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 5c3e256) Co-authored-by: Kyle Pollich <[email protected]>
…#154612) ## Summary _Please review with [whitespace ignore](https://github.com/elastic/kibana/pull/154612/files?diff=unified&w=1)!_ In #143097 the conditional for showing `Advanced options` was removed as we introduced experimental indexing toggles which are always shown. However in #148418 (8.7) we put the indexing toggles behind a feature flag. This caused the `Advanced options` toggle to always be shown regardless of there is any content underneath. I spotted this while testing something unrelated. This PR fixes that by adding a condition back that is based on aggregating the conditionals of everything underneath (existence of advanced vars, whether pipelines & mappings are shown, and if experimental indexing toggles are enabled).
…elastic#154612) ## Summary _Please review with [whitespace ignore](https://github.com/elastic/kibana/pull/154612/files?diff=unified&w=1)!_ In elastic#143097 the conditional for showing `Advanced options` was removed as we introduced experimental indexing toggles which are always shown. However in elastic#148418 (8.7) we put the indexing toggles behind a feature flag. This caused the `Advanced options` toggle to always be shown regardless of there is any content underneath. I spotted this while testing something unrelated. This PR fixes that by adding a condition back that is based on aggregating the conditionals of everything underneath (existence of advanced vars, whether pipelines & mappings are shown, and if experimental indexing toggles are enabled). (cherry picked from commit 2636262) # Conflicts: # x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/components/steps/components/package_policy_input_stream.tsx
…howing (#154612) (#154784) # Backport This will backport the following commits from `main` to `8.7`: - [[Fleet] Fix "Advanced options" toggle in policy editor always showing (#154612)](#154612) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-11T18:32:05Z","message":"[Fleet] Fix \"Advanced options\" toggle in policy editor always showing (#154612)\n\n## Summary\r\n\r\n_Please review with [whitespace\r\nignore](https://github.com/elastic/kibana/pull/154612/files?diff=unified&w=1)!_\r\n\r\nIn #143097 the conditional for showing `Advanced options` was removed as\r\nwe introduced experimental indexing toggles which are always shown.\r\nHowever in #148418 (8.7) we put the indexing toggles behind a feature\r\nflag. This caused the `Advanced options` toggle to always be shown\r\nregardless of there is any content underneath. I spotted this while\r\ntesting something unrelated.\r\n\r\nThis PR fixes that by adding a condition back that is based on\r\naggregating the conditionals of everything underneath (existence of\r\nadvanced vars, whether pipelines & mappings are shown, and if\r\nexperimental indexing toggles are enabled).","sha":"2636262e093f188e4937d192d302607eeaafff85","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.8.0"],"number":154612,"url":"https://github.com/elastic/kibana/pull/154612","mergeCommit":{"message":"[Fleet] Fix \"Advanced options\" toggle in policy editor always showing (#154612)\n\n## Summary\r\n\r\n_Please review with [whitespace\r\nignore](https://github.com/elastic/kibana/pull/154612/files?diff=unified&w=1)!_\r\n\r\nIn #143097 the conditional for showing `Advanced options` was removed as\r\nwe introduced experimental indexing toggles which are always shown.\r\nHowever in #148418 (8.7) we put the indexing toggles behind a feature\r\nflag. This caused the `Advanced options` toggle to always be shown\r\nregardless of there is any content underneath. I spotted this while\r\ntesting something unrelated.\r\n\r\nThis PR fixes that by adding a condition back that is based on\r\naggregating the conditionals of everything underneath (existence of\r\nadvanced vars, whether pipelines & mappings are shown, and if\r\nexperimental indexing toggles are enabled).","sha":"2636262e093f188e4937d192d302607eeaafff85"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/154612","number":154612,"mergeCommit":{"message":"[Fleet] Fix \"Advanced options\" toggle in policy editor always showing (#154612)\n\n## Summary\r\n\r\n_Please review with [whitespace\r\nignore](https://github.com/elastic/kibana/pull/154612/files?diff=unified&w=1)!_\r\n\r\nIn #143097 the conditional for showing `Advanced options` was removed as\r\nwe introduced experimental indexing toggles which are always shown.\r\nHowever in #148418 (8.7) we put the indexing toggles behind a feature\r\nflag. This caused the `Advanced options` toggle to always be shown\r\nregardless of there is any content underneath. I spotted this while\r\ntesting something unrelated.\r\n\r\nThis PR fixes that by adding a condition back that is based on\r\naggregating the conditionals of everything underneath (existence of\r\nadvanced vars, whether pipelines & mappings are shown, and if\r\nexperimental indexing toggles are enabled).","sha":"2636262e093f188e4937d192d302607eeaafff85"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Closes #143094
Backporting to 8.5.x since #140132 landed in 8.5.
Screen recording of independent toggle state
Screen.Recording.2022-10-11.at.10.59.29.AM.mov