[Lens][TSVB] Functional tests for converting of Top N. #143181
Conversation
…meseries_top_n_functional_tests
…meseries_top_n_functional_tests
VladLasitsa
added
Feature:TSVB
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
| it('should not allow converting of not valid panel', async () => { | ||
| await visualBuilder.selectAggType('Max'); | ||
| await header.waitUntilLoadingHasFinished(); | ||
| const canEdit = await testSubjects.exists('visualizeEditInLensButton'); |
There was a problem hiding this comment.
I think we have it in other places too, but could we move this to the visualize page as it's such a common call?
There was a problem hiding this comment.
I moved this part and also click by this button in visualize page. Updated all existing functional tests which used this.
| it('should preserve query in lens', async () => { | ||
| let button = await testSubjects.find('visualizeEditInLensButton'); | ||
| await button.click(); | ||
| await lens.waitForVisualization('xyVisChart'); |
There was a problem hiding this comment.
why going to Lens, then back, then setting the query instead of directly setting it?
There was a problem hiding this comment.
You are right, removed this part
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…n_functional_tests' into navigate_to_lens_timeseries_top_n_functional_tests
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @VladLasitsa |
Summary
Completes part of #138236
Ran it 100 times - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1422 - it was successful