Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens][Agg based Metric] Navigate to lens functional tests. #143269

Merged
merged 22 commits into from
Oct 17, 2022
Merged

[Lens][Agg based Metric] Navigate to lens functional tests. #143269

merged 22 commits into from
Oct 17, 2022

Conversation

Kuznietsov
Copy link
Contributor

@Kuznietsov Kuznietsov commented Oct 13, 2022 •
edited
Loading

Summary

Completes part of #138236

  • Static value (reference lines/formula/static value column for different visualizations)
  • Count
  • Metric with source field
  • Sibling pipeline
  • Parent pipeline
  • Not supported aggregations or field type.
  • Invalid aggregations
  • Color rules

Flaky tests check: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1424

@Kuznietsov
Added timeseries test for reference line.
a200b33
@Kuznietsov
Fixed tests for the prupose of running separatelly.
c8353b5
@Kuznietsov
Added test for metric with params.
748a861
@Kuznietsov
Added test for invalid model.
feb2cef
@Kuznietsov
Added test for unsupported aggregation.
134585d
@Kuznietsov
Merge branch 'main' into navigate-to-lens-tsvb-timeseries-functional-…
b60d4e3 
…tests
@Kuznietsov
Added test for sibling pipeline agg.
60e2d71
@Kuznietsov
Added parent pipeline agg tests.
4fa65c1
@Kuznietsov
Merge branch 'navigate-to-lens-tsvb-timeseries-functional-tests' into…
c45f4c2 
… navigate-to-lens-tsvb-metric-functional-tests
@Kuznietsov
Added functional tests for static value.
72ad37b
@Kuznietsov
Added tests for converting metric with params, unsupported metrics an…
595c9b4 
…d not valid panels.
@Kuznietsov
Added tests for color ranges.
ed63c1a
@Kuznietsov
Merge branch 'main' into navigate-to-lens-tsvb-metric-functional-tests
34ad678 
# Conflicts:
#	test/functional/page_objects/visual_builder_page.ts
#	x-pack/test/functional/apps/lens/group3/open_in_lens/tsvb/timeseries.ts
@Kuznietsov
Merge branch 'main' into navigate-to-lens-agg-based-metric-functional…
53abd1d 
…-tests
@Kuznietsov
Added tests for metric with params
5a7a6f1
@Kuznietsov Kuznietsov requested a review from alexwizp October 13, 2022 10:24
@Kuznietsov Kuznietsov self-assigned this Oct 13, 2022
@Kuznietsov Kuznietsov added the WIP Work in progress label Oct 13, 2022
@Kuznietsov Kuznietsov mentioned this pull request Oct 13, 2022
Closed
28 tasks
@Kuznietsov Kuznietsov added loe:small Small Level of Effort test_xpack_functional Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. backport:skip This commit does not require backporting labels Oct 13, 2022
@Kuznietsov Kuznietsov added v8.6.0 and removed WIP Work in progress labels Oct 13, 2022
@Kuznietsov Kuznietsov marked this pull request as ready for review October 13, 2022 15:07
@Kuznietsov Kuznietsov requested a review from a team as a code owner October 13, 2022 15:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@Kuznietsov Kuznietsov added the release_note:skip Skip the PR/issue when compiling release notes label Oct 13, 2022
flash1293
flash1293 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x-pack/test/functional/apps/lens/group3/open_in_lens/agg_based/metric.ts Outdated Show resolved Hide resolved
@Kuznietsov
Merge branch 'main' into navigate-to-lens-agg-based-metric-functional…
ee93658 
…-tests

# Conflicts:
#	x-pack/test/functional/apps/lens/group3/open_in_lens/agg_based/metric.ts
@Kuznietsov
Refactored tests.
48ad420
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

VladLasitsa
VladLasitsa approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kuznietsov Kuznietsov merged commit 4b88273 into elastic:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@VladLasitsa VladLasitsa VladLasitsa approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test_xpack_functional v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kuznietsov @elasticmachine @kibana-ci @flash1293 @VladLasitsa