Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens][Agg based Table] Navigate to lens functional tests. #143290

Merged
merged 2 commits into from
Oct 14, 2022
Merged

[Lens][Agg based Table] Navigate to lens functional tests. #143290

merged 2 commits into from
Oct 14, 2022

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa commented Oct 13, 2022 •
edited
Loading

Summary

Completes part of #138236

  • Static value (reference lines/formula/static value column for different visualizations)
  • Count
  • Metric with source field
  • Sibling pipeline
  • Parent pipeline
  • Not supported aggregations.
  • Invalid aggregations
  • Percentage column
  • Total function
  • Split rows/split tables

@VladLasitsa VladLasitsa self-assigned this Oct 13, 2022
@VladLasitsa VladLasitsa added Feature:Data Table Data table visualization feature test_xpack_functional Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting v8.6.0 labels Oct 13, 2022
@VladLasitsa VladLasitsa mentioned this pull request Oct 13, 2022
Closed
28 tasks
@VladLasitsa VladLasitsa marked this pull request as ready for review October 14, 2022 08:49
@VladLasitsa VladLasitsa requested a review from a team as a code owner October 14, 2022 08:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTable 16.2KB 16.2KB +62.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa merged commit c8a2ee2 into elastic:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels
backport:skip This commit does not require backporting Feature:Data Table Data table visualization feature Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test_xpack_functional v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VladLasitsa @elasticmachine @kibana-ci @flash1293 @kibanamachine