Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Terminal Output] Truncated process output msg #143304

Merged
merged 20 commits into from
Oct 25, 2022
Merged

[Terminal Output] Truncated process output msg #143304

merged 20 commits into from
Oct 25, 2022

Conversation

mitodrummer
Copy link
Contributor

@mitodrummer mitodrummer commented Oct 13, 2022 •
edited by kibanamachine
Loading

Summary

Ansi crafted message added to tty player when a process exceeds max_kilobytes_per_process advanced policy setting. [ VIEW POLICIES ] inline link will navigate to /security/administration/policy page. Permissions are checked to ensure only users who can access the management page see the link.

image

xterm updated to v5, which unlocks ansi hyperlink escape codes. Some breaking changes were fixed in the process.
#141179 <-- xterm renovate PR

Checklist

Delete any items that are not applicable to this PR.

@mitodrummer mitodrummer added release_note:enhancement Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.5.1 labels Oct 13, 2022
@mitodrummer mitodrummer requested a review from a team October 13, 2022 16:43
@mitodrummer mitodrummer requested a review from a team as a code owner October 13, 2022 16:43
opauloh
opauloh reviewed Oct 13, 2022
View reviewed changes
...urity_solution/public/timelines/components/timeline/session_tab_content/use_session_view.tsx
@@ -224,6 +225,8 @@ export const useSessionView = ({
const { globalFullScreen } = useGlobalFullScreen();
const { timelineFullScreen } = useTimelineFullScreen();

const { canAccessEndpointManagement } = useUserPrivileges().endpointPrivileges;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about this one, nice!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does using the canAccessEndpointManagement accomplish?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ansi message will contain a link to /security/administration/policy which is a listing of the defend integration policies. Only users with this permission can access it. I'm passing it as a parameter since I can't import this hook into session_view as it would introduce a circular dependency.

opauloh
opauloh approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM / minor comments

@Omolola-Akinleye Omolola-Akinleye self-requested a review October 13, 2022 20:25
@mitodrummer mitodrummer added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 18, 2022
@mitodrummer mitodrummer enabled auto-merge (squash) October 25, 2022 18:52
@mitodrummer mitodrummer merged commit 97a68d8 into elastic:main Oct 25, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #4 / Timeline search and filters Update kqlMode for timeline "before all" hook for "should be able to update timeline kqlMode with filter"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
sessionView 102 104 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.5MB 9.6MB +318.0B
sessionView 454.5KB 379.1KB -75.3KB
total -75.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
sessionView 48.8KB 48.9KB +108.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.5 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 143304

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Oct 26, 2022
Merged
1 task
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 143304 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 26, 2022
@mitodrummer mitodrummer deleted the truncated_output_msg branch October 26, 2022 23:57
@mitodrummer mitodrummer added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 26, 2022
@kibanamachine kibanamachine mentioned this pull request Nov 3, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

@opauloh opauloh opauloh approved these changes

@Omolola-Akinleye Omolola-Akinleye Awaiting requested review from Omolola-Akinleye

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.5.1 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mitodrummer @kibana-ci @kibanamachine @Omolola-Akinleye @opauloh @kqualters-elastic