Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens][TSVB] Navigate to Lens TSVB Table. #143814

Closed
wants to merge 21 commits into from
Closed

[Lens][TSVB] Navigate to Lens TSVB Table. #143814

wants to merge 21 commits into from

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa commented Oct 21, 2022 •
edited
Loading

Completes part of #138236

Summary

As part of phasing out TSVB and Visualize all Legacy agg based visulizations should support "open in lens" functionality.
In that PR converter for TSVB Table was added.

Some conversion remarks:

  • “Group by field” becomes row split by top values
  • Ignore trend arrows
  • Convert sorting config on the table into client side sorting of Lens table
  • Convert “Field” + “Aggregate function” into a second row split dimension by top values which is collapsed by the aggregate function

Some block cases:

  • Several series have different “Field” + “Aggregate function”
  • “Aggregate function” is not max, min, avg, sum
  • Several fields in “Group by field” where one of them is date field
  • Only static value metics are visible

@VladLasitsa VladLasitsa self-assigned this Oct 21, 2022
@VladLasitsa VladLasitsa added release_note:enhancement Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes v8.6.0 and removed release_note:enhancement labels Oct 21, 2022
@VladLasitsa VladLasitsa mentioned this pull request Oct 21, 2022
Closed
28 tasks
@VladLasitsa VladLasitsa marked this pull request as ready for review October 24, 2022 13:45
@VladLasitsa VladLasitsa requested a review from a team as a code owner October 24, 2022 13:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@VladLasitsa VladLasitsa requested a review from flash1293 October 24, 2022 13:45
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

MiriamAparicio and others added 5 commits October 25, 2022 09:50
@MiriamAparicio
[APM] Extract apmEventClient from setupRequest (elastic#143863)
3d92c3f 
* Extract apmEventClient from setupRequest

* continue refactor and fix tests
@walterra
Call p-value aggs in parallel. (elastic#143722)
51ec724 
In the analysis part we created chunks of 10 calls for the p-value aggregations, but individual calls of these chunks were then still called one after the other. This PR changes the behaviour to run calls for each chunk in parallel.
@shahzad31
[Synthetics] Update data view permission test (elastic#143921)
13f2fab
@afharo
[LaunchDarkly] Promote Cloud Experiments documentation in the Dev Docs (
76e9dd4 
elastic#143885)
@LucaWintergerst @kibanamachine @rockdaboot
[Profiling] allow negative numbers in formatter (elastic#143420)
003bbf7 
* Update as_number.ts

allow negative numbers in formatter. Currently all negative values get truncated to `~0.00`
closes elastic/prodfiler#2707

* Update as_number.ts

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* Update as_number.ts

change negative condition to abs

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 380 382 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
visualizations 729 730 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 503.6KB 509.3KB +5.7KB
visualizations 268.2KB 268.2KB +23.0B
total +5.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeTimeseries 19.6KB 19.7KB +113.0B
Unknown metric groups

API count

id before after diff
visualizations 759 760 +1

async chunk count

id before after diff
visTypeTimeseries 15 16 +1

History

  • 💔 Build #82167 failed d3d0911d18b97d61d2c05ee4fe16422a5b9b49d5
  • 💚 Build #82118 succeeded 8b1ef2ca144fc4686bc8910c6f19a670b2df802d
  • 💔 Build #82107 failed 236cfb339776847be64496d65051943cc6c76338
  • 💚 Build #81963 succeeded 179003a196de030e0f8ac6d54050a1e21696d60f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

yashtewari and others added 8 commits October 25, 2022 15:54
@yashtewari @oren-zohar
Edit Agent manifest to mount node's /etc directory. (elastic#143492)
8acccce 
Corresponding change made in Agent repository with:
elastic/elastic-agent#1382

Co-authored-by: Yash Tewari <[email protected]>
Co-authored-by: Oren Zohar <[email protected]>
@nchaulet
[Fleet] Fix error in agent policy duplication (elastic#143884)
d75015c
@afharo
[EBT] Report viewport size (elastic#143854)
a30f691
@maximpn
Fix invalid license info link (elastic#143836)
c53909f 
**Relates to:** [elastic#137148](elastic#137148)

## Summary

Fixes an invalid link to the Platinum license info from the disabled ML rule card.

*Before:*

https://user-images.githubusercontent.com/3775283/197490117-b209250a-5fb9-49c8-bbd4-163aa649fd18.mov

*After:*

https://user-images.githubusercontent.com/3775283/197489478-ef7b428e-cc15-4f62-857b-1f53d5ae1325.mov


### Checklist

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@felixbarny
Add missing options to APM central config (elastic#143668)
b338633
@kibanamachine
skip failing test suite (elastic#143109)
293b2f8
@afharo
Add Onboarding Setup Guide link in the help section when running on C…
08331ad 
…loud (elastic#143765)
@machadoum
[Security Solution] Allow Users to launch Timeline from the Entity An…
227e045 
…alytics dashboard (elastic#143841)

* Add alerts count column to Entity Analytics risk tables
@jloleysens
[Files] Fix image intersection observer behavior (elastic#143843)
37454b7 
* react with loading spinner to new page or retry requests

* do not fetch on every change? in files example app

* remove lazy from the file picker image

* absolute position the image tag to ensure that it is visible, this ensures the intersection observer will fire

* remove the "lazy" prop from the image component

* remove unnecessary if

* added comment and increase page size of file picker in files example plugin

* make the empty "hidden" image occupy the full container space
@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Oct 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@VladLasitsa VladLasitsa marked this pull request as draft October 25, 2022 12:52
@VladLasitsa
Copy link
Contributor Author

Close PR, some problems with rebase on master here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 Awaiting requested review from flash1293

Assignees

@VladLasitsa VladLasitsa

Labels
backport:skip This commit does not require backporting Feature:Lens Feature:TSVB TSVB (Time Series Visual Builder) release_note:feature Makes this part of the condensed release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.