-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] add in product help for layer group drag and drop instructions #144259
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
Here's a suggestion: Drag layers in and out of the group
Question: Is it clear to users that they populate the group in the Layers list? Or should we add that wording in the write-up above? If you just was want a simple feature announcement: Drag layers in and out of the group in the Layers list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code and UI changes lgtm!
I also agree with @gchaps suggestions for improving the text.
Drag layers in and out of the group in the Layers list.
👍
@elasticmachine merge upstream |
.../plugins/maps/public/connected_components/edit_layer_panel/layer_settings/layer_settings.tsx
Outdated
Show resolved
Hide resolved
.../plugins/maps/public/connected_components/edit_layer_panel/layer_settings/layer_settings.tsx
Outdated
Show resolved
Hide resolved
.../plugins/maps/public/connected_components/edit_layer_panel/layer_settings/layer_settings.tsx
Outdated
Show resolved
Hide resolved
<> | ||
<EuiCallOut | ||
title={i18n.translate('xpack.maps.layerPanel.settingsPanel.layerGroupCalloutTitle', { | ||
defaultMessage: 'Use drag and drop to populate layer group', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about "Drag layers in and out of the group" for the title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, lets use that title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few minor comments
…el/layer_settings/layer_settings.tsx Co-authored-by: gchaps <[email protected]>
…el/layer_settings/layer_settings.tsx Co-authored-by: gchaps <[email protected]>
…el/layer_settings/layer_settings.tsx Co-authored-by: gchaps <[email protected]>
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Follow up to #142528
Drag and drop features can be hard to discover. This PR adds some in product help that describes how to use drag and drop to add and remove layers from a layer group.