Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] add in product help for layer group drag and drop instructions #144259

Merged
merged 10 commits into from
Nov 2, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 31, 2022

Follow up to #142528

Drag and drop features can be hard to discover. This PR adds some in product help that describes how to use drag and drop to add and remove layers from a layer group.

Screen Shot 2022-11-01 at 12 15 46 PM

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.6.0 labels Oct 31, 2022
@nreese nreese marked this pull request as ready for review October 31, 2022 18:20
@nreese nreese requested a review from a team as a code owner October 31, 2022 18:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese requested a review from gchaps October 31, 2022 18:20
@gchaps
Copy link
Contributor

gchaps commented Oct 31, 2022

Here's a suggestion:

Drag layers in and out of the group

  • To add your first layer, drag it onto the group name.
  • To add another layer, drag it anywhere above the last group layer.
  • To remove a layer, drag it above or below the group.

Question: Is it clear to users that they populate the group in the Layers list? Or should we add that wording in the write-up above?

If you just was want a simple feature announcement:

Drag layers in and out of the group in the Layers list.

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code and UI changes lgtm!

I also agree with @gchaps suggestions for improving the text.

Drag layers in and out of the group in the Layers list.

👍

@nreese
Copy link
Contributor Author

nreese commented Nov 1, 2022

@elasticmachine merge upstream

<>
<EuiCallOut
title={i18n.translate('xpack.maps.layerPanel.settingsPanel.layerGroupCalloutTitle', {
defaultMessage: 'Use drag and drop to populate layer group',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about "Drag layers in and out of the group" for the title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, lets use that title.

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor comments

nreese and others added 4 commits November 2, 2022 08:54
…el/layer_settings/layer_settings.tsx

Co-authored-by: gchaps <[email protected]>
…el/layer_settings/layer_settings.tsx

Co-authored-by: gchaps <[email protected]>
…el/layer_settings/layer_settings.tsx

Co-authored-by: gchaps <[email protected]>
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +884.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 443 +4
total +17

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 520 +4
total +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 8ea2f3b into elastic:main Nov 2, 2022
@sophiec20 sophiec20 added Feature:Maps and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Maps release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants