-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Fix rules table refresh after rule's import #144359
[Security Solution] Fix rules table refresh after rule's import #144359
Conversation
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @maximpn |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
@banderror @xcrzx AFAIK we have file structure changes and usage of React Query hooks since starting from 8.6 so back-porting does't look safe here. WDYT? |
@maximpn ++, I guess backporting would require fixing it from scratch in 8.5, I'd not spend time on that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested locally, but the code changes LGTM 👍
Resolves: #136758
Summary
It fixes the problem of the rules table refresh after importing a rule.
Before:
Screen.Recording.2022-11-01.at.21.14.58.mov
After:
Screen.Recording.2022-11-01.at.21.18.10.mov
Checklist