[Fleet] Do not add field with index:false to query default value #145410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2022
…stic#145410) (cherry picked from commit ca68c0f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
#145410) (#145601) # Backport This will backport the following commits from `main` to `8.6`: - [[Fleet] Do not add field with index:false to query default value (#145410)](#145410) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T17:14:44Z","message":"[Fleet] Do not add field with index:false to query default value (#145410)","sha":"ca68c0f9a6c5ef981de59355cc444556e329cff6","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v8.6.0","v8.7.0"],"number":145410,"url":"https://github.com/elastic/kibana/pull/145410","mergeCommit":{"message":"[Fleet] Do not add field with index:false to query default value (#145410)","sha":"ca68c0f9a6c5ef981de59355cc444556e329cff6"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145410","number":145410,"mergeCommit":{"message":"[Fleet] Do not add field with index:false to query default value (#145410)","sha":"ca68c0f9a6c5ef981de59355cc444556e329cff6"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #143936
We should not add field with index.false or doc_values:false to the default query settings. That PR fix that.
Added some unit test to the settings generation.