Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELS-8] - [Synthetics] Refactor monitor detail flyout #147828

Closed
wants to merge 2 commits into from
Closed

[ELS-8] - [Synthetics] Refactor monitor detail flyout #147828

wants to merge 2 commits into from

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Dec 20, 2022 •
edited
Loading

What this PR does / why we need it:

  • Split the MonitorStatus component into a general-purpose status UI
  • Create a new presentation component to use in the flyout to wrap monitor status data
  • Create a new folder in which to nest the monitor flyout components
  • Split out sizable chunks of UI code into smaller components/files where appropriate

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

Demo

Only refactoration, Demo not available.

@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@gitstart gitstart changed the title [ELS-8] - [Synthetics] Refactor monitor detail flyout #8 [ELS-8] - [Synthetics] Refactor monitor detail flyout Dec 20, 2022
@gitstart gitstart marked this pull request as ready for review December 20, 2022 09:12
@gitstart gitstart requested a review from a team as a code owner December 20, 2022 09:12
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Dec 20, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31
Copy link
Contributor

i don't think, this serves any purpose.

@shahzad31 shahzad31 closed this Dec 20, 2022
@gitstart
Copy link
Contributor Author

@shahzad31 Would this issue be closed as well #145422?

As this was the initial purpose of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
💝community Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gitstart @kibanamachine @elasticmachine @shahzad31