[Fleet] Generate time_series_metric when metric_type is set

[nchaulet]

Summary

Resolve #148057

Generate time_series_metric for every field when metric_type is set.
The previous implementation was only doing it for scaled float.

That PR also remove metric_type from meta as the original issue mentioned to keep only meta.unit #115621

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 6ddea1d

Metrics [docs]

✅ unchanged

History

• 💚 Build #99309 succeeded a0e49e6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

[juliaElastic]

Thanks for fixing 🚀

[ruflin]

The new implementation does not do any validation if the field supports metric_type. This might have the advantage, that if more field types are added in the future, no code changes are needed. As this code is used by packages, it should be ensured that elastic-package does the validation.

[nchaulet]

The new implementation does not do any validation if the field supports metric_type. This might have the advantage, that if more field types are added in the future, no code changes are needed. As this code is used by packages, it should be ensured that elastic-package does the validation.

@ruflin it will be great if elastic-package validate this and it will probably improve a lot the developper experience, but worse case scenario currently the package installation will fail, and the package developper will still have some feedback something is not correct

For example adding metric_type on a keyword field

[ruflin]

@nchaulet Looks good. Can you follow up on the spec validation?

[nchaulet]

@ruflin @kpollich Looks like that change break some dashboard the elastic_agent one for example (system too) some aggregation seems to not work anymore we get the following error for fields defining metric type

Should we generate time_series_metric only if the datastream enabled index mode timeserie?

[kpollich]

Should we generate time_series_metric only if the datastream enabled index mode timeserie?

Yes this seems like a safe bet - better to not assume any and all fields will have time series indexing enabled at some point in the future.

[ruflin]

Should we generate time_series_metric only if the datastream enabled index mode timeserie?

Yes! Otherwise it is tricky to test the feature. I expect many packages will add the field but still have time series off but turn it on first for testing.