Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.6] [Fleet] Fix max 20 installed integrations returned from Fleet API (#150780) #150891

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

kpollich
Copy link
Member

Backport

This will backport the following commits from main to 8.6:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Kyle Pollich "}},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/150780","number":150780,"mergeCommit":{"message":"[Fleet] Fix max 20 installed integrations returned from Fleet API (#150780)\n\n## Summary\r\n\r\nFix an (old) bug where Fleet's \"list packages\" API endpoint would only\r\never return 20 installed integrations at most.\r\n\r\nI haven't included a test case here because I'm not sure we have 20 test\r\npackages that can reasonably be installed at the same time. Also feels\r\nlike an arbitrary number to introduce a \"lists all packages even if\r\nthere are more N\" test case. Open to feedback on testing.\r\n\r\n## Before\r\n\r\n23 installed integrations, only 20 in UI\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/6766512/217930020-f6dafe56-191a-48c0-acb4-c567810a6dad.png)\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/6766512/217930126-441e78a8-d484-4c5d-b5df-00179d930e4a.png)\r\n\r\n## After\r\n\r\n23 installed integrations, 23 in UI\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/6766512/217930384-21506d77-7244-42c1-93bd-97025a8ec86e.png)","sha":"e7209f52a91170ce3e53d2bd27bafaecf6195d54"}}]}] BACKPORT-->

…astic#150780)

## Summary

Fix an (old) bug where Fleet's "list packages" API endpoint would only
ever return 20 installed integrations at most.

I haven't included a test case here because I'm not sure we have 20 test
packages that can reasonably be installed at the same time. Also feels
like an arbitrary number to introduce a "lists all packages even if
there are more N" test case. Open to feedback on testing.

## Before

23 installed integrations, only 20 in UI

![image](https://user-images.githubusercontent.com/6766512/217930020-f6dafe56-191a-48c0-acb4-c567810a6dad.png)

![image](https://user-images.githubusercontent.com/6766512/217930126-441e78a8-d484-4c5d-b5df-00179d930e4a.png)

## After

23 installed integrations, 23 in UI

![image](https://user-images.githubusercontent.com/6766512/217930384-21506d77-7244-42c1-93bd-97025a8ec86e.png)

(cherry picked from commit e7209f5)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 61 67 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 69 75 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kpollich kpollich merged commit aabd37e into elastic:8.6 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants