Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Warn user when they are sending data to stream managed by different integration #151075

Merged

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Feb 13, 2023

Summary

Closes #149427

Give the user a warning if they are sending data to a data stream that isn't managed by the integration being added.

Screenshot 2023-02-13 at 21 17 13

@hop-dev hop-dev added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0 v8.8.0 labels Feb 13, 2023
@hop-dev hop-dev requested a review from a team as a code owner February 13, 2023 21:10
@hop-dev hop-dev self-assigned this Feb 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@hop-dev hop-dev requested a review from kpollich February 13, 2023 21:10
@hop-dev
Copy link
Contributor Author

hop-dev commented Feb 13, 2023

@kpollich some more copy for you to look over 😅

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 927.0KB 927.9KB +924.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hop-dev hop-dev merged commit 25d4c9f into elastic:main Feb 14, 2023
@hop-dev hop-dev deleted the 149427-warn-when-sending-data-to-existing-stream branch February 14, 2023 14:40
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 14, 2023
…ferent integration (elastic#151075)

## Summary

Closes elastic#149427

Give the user a warning if they are sending data to a data stream that
isn't managed by the integration being added.

<img width="697" alt="Screenshot 2023-02-13 at 21 17 13"
src="https://user-images.githubusercontent.com/3315046/218576500-a0817207-451e-47c5-ba0b-d0faaddca1a4.png">

(cherry picked from commit 25d4c9f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 14, 2023
…by different integration (#151075) (#151146)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Fleet] Warn user when they are sending data to stream managed by
different integration
(#151075)](#151075)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mark
Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-14T14:40:46Z","message":"[Fleet]
Warn user when they are sending data to stream managed by different
integration (#151075)\n\n## Summary\r\n\r\nCloses #149427\r\n\r\nGive
the user a warning if they are sending data to a data stream
that\r\nisn't managed by the integration being added.\r\n\r\n<img
width=\"697\" alt=\"Screenshot 2023-02-13 at 21 17
13\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/218576500-a0817207-451e-47c5-ba0b-d0faaddca1a4.png\">","sha":"25d4c9f3297bfcf685287d4b0fd3a91934d8eb04","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.7.0","v8.8.0"],"number":151075,"url":"https://github.com/elastic/kibana/pull/151075","mergeCommit":{"message":"[Fleet]
Warn user when they are sending data to stream managed by different
integration (#151075)\n\n## Summary\r\n\r\nCloses #149427\r\n\r\nGive
the user a warning if they are sending data to a data stream
that\r\nisn't managed by the integration being added.\r\n\r\n<img
width=\"697\" alt=\"Screenshot 2023-02-13 at 21 17
13\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/218576500-a0817207-451e-47c5-ba0b-d0faaddca1a4.png\">","sha":"25d4c9f3297bfcf685287d4b0fd3a91934d8eb04"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151075","number":151075,"mergeCommit":{"message":"[Fleet]
Warn user when they are sending data to stream managed by different
integration (#151075)\n\n## Summary\r\n\r\nCloses #149427\r\n\r\nGive
the user a warning if they are sending data to a data stream
that\r\nisn't managed by the integration being added.\r\n\r\n<img
width=\"697\" alt=\"Screenshot 2023-02-13 at 21 17
13\"\r\nsrc=\"https://user-images.githubusercontent.com/3315046/218576500-a0817207-451e-47c5-ba0b-d0faaddca1a4.png\">","sha":"25d4c9f3297bfcf685287d4b0fd3a91934d8eb04"}}]}]
BACKPORT-->

Co-authored-by: Mark Hopkin <[email protected]>
justinkambic pushed a commit to justinkambic/kibana that referenced this pull request Feb 23, 2023
…ferent integration (elastic#151075)

## Summary

Closes elastic#149427

Give the user a warning if they are sending data to a data stream that
isn't managed by the integration being added.

<img width="697" alt="Screenshot 2023-02-13 at 21 17 13"
src="https://user-images.githubusercontent.com/3315046/218576500-a0817207-451e-47c5-ba0b-d0faaddca1a4.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Warn/inform user when they elect to send data to an existing data stream
5 participants