[8.7] [Fleet] Fix agent policy selection and creation when there are a large number of agent policies ( > 1k) (#151119) #151131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e number of agent policies ( > 1k) (elastic#151119) ## Summary Closes elastic#150605 When adding an integration, the agent policy selector (create or select existing agent policy) does not work if there are too many agent policies. In an environment with a large number of agent policies (e.g 1000+) the following API request times out or takes 30 - 60 seconds to respond: ``` http://localhost:5601/mark/api/fleet/agent_policies?page=1&perPage=10000&sortField=name&sortOrder=asc&full=true ``` That is because for each agent policy we get the saved object twice, get ALL package policies, and count the agents, so for 1000 agents we fun 4000 queries using `pmap` in some places. this PR changes it so that we do not get the agent count or `full` agent policy for every agent policy when populating the agent policy select, instead we only get the selected agent policy. This has meant that I have to separately query package policies in order to do the limited packages and APM output checks, but the component now loads instantly on an environment with 3k agent policies. Key changes: - add `noAgentCount` query param to agent policies API, to not count the agents for all agent policies - populate `agents` in the get one agent policy API, this was an inconsistency in our agent policy API - when selecting an existing agent policy, only get the full agent policy for the selected agent policy ###Testing No behaviour should have changed for the agent policy select, some niche behaviour of the selector: - if adding the APM integration, any agent policy with a logstash output configured for integration data should be disabled - if adding a limited integration e.g apm or defend, any agent policy already containing that integration should be disabled <img width="1052" alt="Screenshot 2023-02-14 at 10 45 03" src="https://user-images.githubusercontent.com/3315046/218745430-4a8f0ded-1e0b-4319-bc2c-cc5253b4cdd2.png"> (cherry picked from commit 9a52ef4)
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @hop-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.7:Questions ?
Please refer to the Backport tool documentation