Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Defend Workflows] Fix Osquery cypress flaky test #151472

Merged
merged 2 commits into from
Feb 21, 2023
Merged

[Defend Workflows] Fix Osquery cypress flaky test #151472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a71c063
force button click in case of opened popup
tomsonpl Feb 16, 2023
52f2901
Merge branch 'main' into fix-test-osquery
tomsonpl Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions x-pack/plugins/osquery/cypress/e2e/all/alerts.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ describe('Alert Event Details', () => {
it('adds response actions with osquery with proper validation and form values', () => {
cy.visit('/app/security/rules');
cy.contains(RULE_NAME).click();
cy.contains('Edit rule settings').click();
cy.contains('Edit rule settings').click({ force: true });
cy.getBySel('edit-rule-actions-tab').wait(500).click();
cy.contains('Response actions are run on each rule execution');
cy.getBySel(OSQUERY_RESPONSE_ACTION_ADD_BUTTON).click();
Expand Down Expand Up @@ -114,7 +114,7 @@ describe('Alert Event Details', () => {
cy.contains('Save changes').click();
cy.contains(`${RULE_NAME} was saved`).should('exist');
cy.getBySel('toastCloseButton').click();
cy.contains('Edit rule settings').click();
cy.contains('Edit rule settings').click({ force: true });
cy.getBySel('edit-rule-actions-tab').wait(500).click();
cy.contains('select * from uptime');
cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
Expand Down Expand Up @@ -158,7 +158,7 @@ describe('Alert Event Details', () => {

cy.contains(`${RULE_NAME} was saved`).should('exist');
cy.getBySel('toastCloseButton').click();
cy.contains('Edit rule settings').click();
cy.contains('Edit rule settings').click({ force: true });
cy.getBySel('edit-rule-actions-tab').wait(500).click();
cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
cy.contains('testpack');
Expand Down Expand Up @@ -198,7 +198,7 @@ describe('Alert Event Details', () => {
'You have queries in the investigation guide. Add them as response actions?';
cy.visit('/app/security/rules');
cy.contains(RULE_NAME).click();
cy.contains('Edit rule settings').click();
cy.contains('Edit rule settings').click({ force: true });
cy.getBySel('edit-rule-actions-tab').wait(500).click();

cy.getBySel(RESPONSE_ACTIONS_ITEM_0).within(() => {
Expand Down