[Synthetics] Fix usage of synthetics-* index pattern the synthetics app #152473
Conversation
shahzad31
changed the title
shahzad31
added
release_note:skip
...vability/public/components/shared/exploratory_view/series_editor/columns/date_picker_col.tsx
Show resolved
Hide resolved
| @@ -75,7 +75,7 @@ export function UptimeSection({ bucketSize }: Props) { | |||
| ] | |||
| ); | |||
|
|
|||
| if (!hasDataMap.synthetics?.hasData) { | |||
| if (!hasDataMap.uptime?.hasData) { | |||
There was a problem hiding this comment.
Not necessarily related to this line, but will we need to add a Synthetics section to the observability overview page before GA?
There was a problem hiding this comment.
i don't think it's needed for GA
| @@ -73,7 +73,7 @@ describe('HasDataContextProvider', () => { | |||
| expect(result.current).toEqual({ | |||
| hasDataMap: { | |||
| apm: { hasData: undefined, status: 'success' }, | |||
| synthetics: { hasData: undefined, status: 'success' }, | |||
| uptime: { hasData: undefined, status: 'success' }, | |||
There was a problem hiding this comment.
Why isn't synthetics included in the hasDataMap, in addition to Uptime?
There was a problem hiding this comment.
because we don't have a UI section or need for that.
| @@ -100,7 +100,7 @@ export function HasDataContextProvider({ children }: { children: React.ReactNode | |||
| serviceName: resultUx?.serviceName as string, | |||
| }); | |||
| break; | |||
| case SYNTHETICS_APP: | |||
| case UPTIME_APP: | |||
There was a problem hiding this comment.
No has data handler for synthetics app?
There was a problem hiding this comment.
because we don't have a UI section or need for that.
| export const useSyntheticsPrivileges = () => { | ||
| const { error } = useSelector(selectOverviewStatus); | ||
|
|
||
| if (error?.body?.message?.startsWith('MissingIndicesPrivileges:')) { |
There was a problem hiding this comment.
Comparing against the error message versus the error type seems a bit brittle to me. What do you think?
There was a problem hiding this comment.
we wanted a more specific comparison here.
x-pack/plugins/synthetics/public/apps/synthetics/hooks/use_synthetics_priviliges.tsx
Show resolved
Hide resolved
| @@ -42,7 +42,7 @@ export const UptimePageTemplateComponent: React.FC<Props & EuiPageTemplateProps> | |||
| inspectorAdapters.requests.reset(); | |||
| }, [inspectorAdapters.requests]); | |||
|
|
|||
| if (error) { | |||
| if (error && path !== SETTINGS_ROUTE) { | |||
There was a problem hiding this comment.
Why was this added?
There was a problem hiding this comment.
for settings page , no data state doesn't make sense.
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
Co-authored-by: Dominique Clarke <[email protected]>
There was a problem hiding this comment.
Smoke testing Uptime and Synthetics LGTM
Smoke tested Synthetics app pages, including exploratory view
Smoke tested Uptime pages, including changing uptime index settings, Exploratory view, and observability overview
Smoke tested no data views in Uptime and Synthetics
Smoke tested no permissions view in Uptime and Synthetics
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
POST FF Testing LGTM !! |
Summary
Following things have been fixed in the PR
Since uptime and synthetics are separate app. Correct usage has been made in exploratory view and observability overview page to reflect that.