[Tech debt] Reorder Overview page #152802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…just-folder-structure-of-overview-page
|
@elasticmachine merge upstream |
…of github.com:CoenWarmer/kibana into chore/152787-adjust-folder-structure-of-overview-page
…just-folder-structure-of-overview-page
CoenWarmer
added
the
release_note:skip
…just-folder-structure-of-overview-page
kdelemme
approved these changes
Mar 8, 2023
| @@ -13,7 +13,7 @@ import { MetricsSection } from '../../../components/app/section/metrics'; | |||
| import { UptimeSection } from '../../../components/app/section/uptime'; | |||
| import { UXSection } from '../../../components/app/section/ux'; | |||
| import { HasDataMap } from '../../../context/has_data_context'; | |||
| import { BucketSize } from '../containers'; | |||
| import { BucketSize } from '../helpers/calculate_bucket_size'; | |||
There was a problem hiding this comment.
Just to be consistent with the other identical import of this type
Suggested change
| import { BucketSize } from '../helpers/calculate_bucket_size'; | |
| import type { BucketSize } from '../helpers/calculate_bucket_size'; |
| import { useUiTracker } from '../../../hooks/use_track_metric'; | ||
| import { ObservabilityAppServices } from '../../../application/types'; | ||
|
|
||
| const CAPABILITIES_KEYS = ['logs', 'infrastructure', 'apm', 'uptime']; | ||
|
|
||
| export const useOverviewMetrics = ({ hasAnyData }: { hasAnyData: boolean | undefined }) => { |
There was a problem hiding this comment.
Should we place hooks used only in one page, into pages/<page_name>/hooks ?
There was a problem hiding this comment.
Yes, agree. This particular hook however will be refactored (most likely it will go away), which is why I left it for now. Will be revisited!
…just-folder-structure-of-overview-page
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
mdefazio
approved these changes
Mar 8, 2023
kibanamachine
added
v8.8.0
backport:skip
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this pull request
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #152787
Summary
This PR updates the Overview Page to follow the newly agreed upon structure for the Observability app.
This PR is part of a larger effort to have all pages in the Observability app follow the same structure so they are more consistent with each other. More details in the epic: #152783
It also cleans up dead and unused components where found.
All design and functionality should be exactly the same as before.
Checklist
<to_name_of_page.tsx>/containersubfolder if availabletranslations.ts/app_root/components/feature/page/<name_of_page>/components/<component_name>.tsx