Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Reorder Alerts page #152888

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Mar 8, 2023

Resolves #152788

Summary

This PR updates the Alerts Page to follow the newly agreed upon structure for the Observability app.

This PR is part of a larger effort to have all pages in the Observability app follow the same structure so they are more consistent with each other. More details in the epic: #152783

It also cleans up dead and unused components where found.

All design and functionality should be exactly the same as before.


Old folder structure:
Screenshot 2023-03-08 at 10 56 55

New folder structure:
Page
Screenshot 2023-03-08 at 10 55 30

Root/components
Screenshot 2023-03-08 at 11 09 48

Checklist

  • Rename page component <to_name_of_page.tsx>
  • Remove /container subfolder if available
  • Try to inline translations in /translations.ts
  • Try to move re-used components to /app_root/components/feature
  • Try to move components that are only used in Page to /page/<name_of_page>/components/<component_name>.tsx

@CoenWarmer CoenWarmer requested review from a team as code owners March 8, 2023 09:52
@CoenWarmer CoenWarmer marked this pull request as draft March 8, 2023 09:53
@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Mar 8, 2023
@CoenWarmer CoenWarmer force-pushed the chore/152788-adjust-folder-structure-of-alerts-page branch 2 times, most recently from 7256c3e to 9e97974 Compare March 8, 2023 10:38
@CoenWarmer CoenWarmer changed the title Reorder Alerts page [Tech Debt] Reorder Alerts page Mar 8, 2023
@CoenWarmer CoenWarmer force-pushed the chore/152788-adjust-folder-structure-of-alerts-page branch from 9e97974 to 825fa29 Compare March 8, 2023 11:08
@CoenWarmer CoenWarmer marked this pull request as ready for review March 8, 2023 14:46
@CoenWarmer CoenWarmer requested a review from a team as a code owner March 8, 2023 14:46
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Mar 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@CoenWarmer CoenWarmer requested a review from simianhacker March 8, 2023 15:42
@CoenWarmer CoenWarmer requested a review from a team as a code owner March 8, 2023 18:17
@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 542 522 -20

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 634 646 +12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB -4.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 88.8KB 88.8KB +8.0B
Unknown metric groups

API count

id before after diff
observability 640 652 +12

ESLint disabled line counts

id before after diff
observability 54 50 -4
securitySolution 432 434 +2
total -2

Total ESLint disabled count

id before after diff
observability 60 56 -4
securitySolution 509 511 +2
total -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apm changes lgtm

Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoenWarmer CoenWarmer merged commit 5ebb988 into elastic:main Mar 9, 2023
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Mar 9, 2023
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust folder structure in Alerts page
7 participants