-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tech Debt] Reorder Alerts page #152888
[Tech Debt] Reorder Alerts page #152888
Conversation
7256c3e
to
9e97974
Compare
9e97974
to
825fa29
Compare
…just-folder-structure-of-alerts-page
Pinging @elastic/apm-ui (Team:APM) |
…just-folder-structure-of-alerts-page
x-pack/plugins/apm/public/components/alerting/ui_components/alert_details_app_section/types.ts
Outdated
Show resolved
Hide resolved
…just-folder-structure-of-alerts-page
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apm changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #152788
Summary
This PR updates the Alerts Page to follow the newly agreed upon structure for the Observability app.
This PR is part of a larger effort to have all pages in the Observability app follow the same structure so they are more consistent with each other. More details in the epic: #152783
It also cleans up dead and unused components where found.
All design and functionality should be exactly the same as before.
Old folder structure:

New folder structure:

Page
Root/components

Checklist
<to_name_of_page.tsx>
/container
subfolder if available/translations.ts
/app_root/components/feature
/page/<name_of_page>/components/<component_name>.tsx