[Tech Debt] Reorder AlertDetail page #152894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoenWarmer
force-pushed
the
chore/152789-reorder-alert-detail-page
branch
from
d0140d4 to
56ee53e
Compare
CoenWarmer
added
the
release_note:skip
CoenWarmer
force-pushed
the
chore/152789-reorder-alert-detail-page
branch
2 times, most recently
from
fcca6b0 to
a875eaf
Compare
CoenWarmer
changed the title
…order-alert-detail-page
CoenWarmer
force-pushed
the
chore/152789-reorder-alert-detail-page
branch
from
a875eaf to
67b16f6
Compare
…order-alert-detail-page
CoenWarmer
force-pushed
the
chore/152789-reorder-alert-detail-page
branch
from
90e65a3 to
a3a9178
Compare
kdelemme
reviewed
Mar 16, 2023
| @@ -41,6 +39,8 @@ export interface AlertSummaryProps { | |||
| alertSummaryFields?: AlertSummaryField[]; | |||
| } | |||
|
|
|||
| const DEFAULT_DATE_FORMAT = 'MMM D, YYYY @ HH:mm:ss.SSS'; | |||
There was a problem hiding this comment.
I know this is not part of the refactoring, but we should keep a not to use uiSettings and the user's defined dateFormat instead of this hard coded format.
There was a problem hiding this comment.
I agree. There are multiple definitions of this const in 2 or 3 pages. Seems like they can be centralized in a better way.
…order-alert-detail-page
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @CoenWarmer |
kibanamachine
added
v8.8.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #152789
Summary
This PR updates the Alert Detail Page to follow the newly agreed upon structure for the Observability app.
This PR is part of a larger effort to have all pages in the Observability app follow the same structure so they are more consistent with each other. More details in the epic: #152783
It also cleans up dead and unused components where found.
All design and functionality should be exactly the same as before.