Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Reorder Cases page #152989

Merged
merged 14 commits into from
Mar 16, 2023

Conversation

CoenWarmer
Copy link
Contributor

Resolves #152985

Summary

This PR updates the Cases Page to follow the newly agreed upon structure for the Observability app.

This PR is part of a larger effort to have all pages in the Observability app follow the same structure so they are more consistent with each other. More details in the epic: #152783

It also cleans up dead and unused components where found.

All design and functionality should be exactly the same as before.

Checklist

  • Rename page component <to_name_of_page.tsx>
  • Remove /container subfolder if available
  • Try to inline translations in /translations.ts
  • Try to move re-used components to /app_root/components/feature
  • Try to move components that are only used in Page to /page/<name_of_page>/components/<component_name>.tsx

@CoenWarmer CoenWarmer requested a review from a team as a code owner March 9, 2023 09:50
@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Mar 9, 2023
@CoenWarmer CoenWarmer force-pushed the chore/152985-reorder-cases-page branch 2 times, most recently from bbe88ab to a76e17a Compare March 9, 2023 10:29
@CoenWarmer CoenWarmer force-pushed the chore/152985-reorder-cases-page branch 2 times, most recently from 992eda8 to 9c2c84a Compare March 9, 2023 12:31
@CoenWarmer CoenWarmer force-pushed the chore/152985-reorder-cases-page branch from 8829624 to ad8f87e Compare March 9, 2023 13:15
@CoenWarmer CoenWarmer changed the title Reorder Cases page [Tech Debt] Reorder Cases page Mar 9, 2023
@CoenWarmer CoenWarmer force-pushed the chore/152985-reorder-cases-page branch from 193452f to 37b7730 Compare March 9, 2023 20:59
@CoenWarmer CoenWarmer force-pushed the chore/152985-reorder-cases-page branch 2 times, most recently from a55c986 to 4982ce8 Compare March 9, 2023 21:12
@CoenWarmer CoenWarmer requested a review from a team as a code owner March 9, 2023 21:12
@CoenWarmer CoenWarmer force-pushed the chore/152985-reorder-cases-page branch from 7ebbee8 to 5fc43aa Compare March 9, 2023 21:29
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoenWarmer CoenWarmer enabled auto-merge (squash) March 16, 2023 11:55
@CoenWarmer CoenWarmer force-pushed the chore/152985-reorder-cases-page branch from b3befee to f6fdd2e Compare March 16, 2023 15:01
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #21 / security APIs - Session Idle Session POST /internal/security/session should extend the session

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 521 517 -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.1MB 1.1MB -1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 88.5KB 88.4KB -145.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 0ca0717 into elastic:main Mar 16, 2023
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust folder structure in Cases page
4 participants