-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Playwright e2e test from Observability #153934
Merged
CoenWarmer
merged 3 commits into
elastic:main
from
CoenWarmer:chore/153884-remove-exploratory-view-from-obs
Mar 29, 2023
Merged
Remove Playwright e2e test from Observability #153934
CoenWarmer
merged 3 commits into
elastic:main
from
CoenWarmer:chore/153884-remove-exploratory-view-from-obs
Mar 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/uptime (Team:uptime) |
37d78eb
to
933d409
Compare
jbudz
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.buildkite
changes LGTM
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @CoenWarmer |
shahzad31
approved these changes
Mar 29, 2023
jgowdyelastic
pushed a commit
to jgowdyelastic/kibana
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v8.8.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #153884
📝 Summary
The Synthetics team placed E2E testing library Playwright inside the Observability app, to test the Exploratory View route.
Now that the Exploratory View route is placed in its own application, this E2E suite is no longer needed as the Obs team uses the FTR suite for end to end testing.
✅ Acceptance Criteria