Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Playwright e2e test from Observability #153934

Conversation

CoenWarmer
Copy link
Contributor

Resolves #153884

📝 Summary

The Synthetics team placed E2E testing library Playwright inside the Observability app, to test the Exploratory View route.

Now that the Exploratory View route is placed in its own application, this E2E suite is no longer needed as the Obs team uses the FTR suite for end to end testing.

✅ Acceptance Criteria

  • E2E setup inside Obs is removed
  • CI definitions updated

@CoenWarmer CoenWarmer requested review from a team as code owners March 29, 2023 12:05
@CoenWarmer CoenWarmer self-assigned this Mar 29, 2023
@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Mar 29, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added this to the 8.8 milestone Mar 29, 2023
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Mar 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@CoenWarmer CoenWarmer force-pushed the chore/153884-remove-exploratory-view-from-obs branch from 37d78eb to 933d409 Compare March 29, 2023 13:04
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.buildkite changes LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
observability 6 5 -1
synthetics 6 7 +1
ux 2 3 +1
total +1

ESLint disabled line counts

id before after diff
observability 50 45 -5
securitySolution 433 436 +3
synthetics 104 107 +3
ux 9 12 +3
total +4

Total ESLint disabled count

id before after diff
observability 56 50 -6
securitySolution 513 516 +3
synthetics 110 114 +4
ux 11 15 +4
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @CoenWarmer

@CoenWarmer CoenWarmer merged commit 0ee2368 into elastic:main Mar 29, 2023
@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Mar 29, 2023
jgowdyelastic pushed a commit to jgowdyelastic/kibana that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability] Remove Playwright E2E from Observability
7 participants