Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use components from Exploratory View app in Synthetics #154056

Merged
merged 10 commits into from
Apr 4, 2023
Merged

Use components from Exploratory View app in Synthetics #154056

merged 10 commits into from
Apr 4, 2023

Conversation

CoenWarmer
Copy link
Contributor

Resolves #154055

📝 Summary

Now that the Exploratory View route is placed in its own application, the Synthetics app can safely use components related to the Exploratory View from that application.

✅ Acceptance Criteria

  • Synthetics app should behave and function exactly the same as before.

@CoenWarmer CoenWarmer requested a review from a team as a code owner March 30, 2023 14:14
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Mar 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label Mar 30, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer force-pushed the chore/update-links-to-exploratory-view-app-in-synthetics branch from bd795cb to 70f6f8b Compare March 30, 2023 14:41
@CoenWarmer CoenWarmer requested a review from a team as a code owner March 30, 2023 14:41
@CoenWarmer CoenWarmer force-pushed the chore/update-links-to-exploratory-view-app-in-synthetics branch 2 times, most recently from a4dbfbc to cffd274 Compare March 31, 2023 11:43
kdelemme
kdelemme approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CoenWarmer CoenWarmer force-pushed the chore/update-links-to-exploratory-view-app-in-synthetics branch from cffd274 to 0f745dd Compare March 31, 2023 13:28
@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

@CoenWarmer
Copy link
Contributor Author

@elasticmachine merge upstream

shahzad31
shahzad31 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM !!

@CoenWarmer CoenWarmer enabled auto-merge (squash) April 4, 2023 10:04
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.4MB 1.4MB +74.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit fc2a0d7 into elastic:main Apr 4, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Exploratory View] Update Synthetics app to use components from Exploratory View
7 participants
@CoenWarmer @elasticmachine @apmmachine @kibana-ci @kdelemme @shahzad31 @kibanamachine