Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedFieldList] Skip requests for time series metric counter field #154319

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Apr 4, 2023

Addresses #152912

Summary

This PR makes sure that unified field list does not call unsupported aggs for counter fields. Also the messaging will be better: instead of No field data for the current search. it will show Analysis is not available for this field.

Screenshot 2023-04-04 at 10 38 29

We might extend it later with a different view for such fields.

@jughosta jughosta added release_note:fix backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Apr 4, 2023
@jughosta jughosta self-assigned this Apr 4, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
unifiedFieldList 45.8KB 45.8KB +64.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta changed the title [UnifiedFieldList] Handle time series metric counter better [UnifiedFieldList] Skip requests for time series metric counter field Apr 4, 2023
@jughosta jughosta marked this pull request as ready for review April 4, 2023 13:03
@jughosta jughosta requested a review from a team as a code owner April 4, 2023 13:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled and tested locally, LGTM 👍

@jughosta jughosta merged commit 93cf614 into elastic:main Apr 6, 2023
@jughosta jughosta deleted the 152912-counter-in-field-list branch April 6, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:UnifiedFieldList The unified field list component used by Lens & Discover release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants