-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps] change event log to use a datastream #154664
Conversation
18eb3a3
to
eebd310
Compare
@elasticmachine merge upstream |
4b847e2
to
ce8cb4c
Compare
1a999ea
to
92f264e
Compare
Pinging @elastic/response-ops (Team:ResponseOps) |
Converted to a draft - shouldn't have taken it out of draft! :-) I've got to add a scheme for this new datastream to co-exist with old-style event log indices. |
92f264e
to
9b372df
Compare
3da45d3
to
c9191c3
Compare
…nd aliases resolves elastic#62677
c9191c3
to
b6a1b80
Compare
@pmuellr In the issue description for changing
Does this also apply to the event log? I see we are still manually creating an ILM policy for the event log |
Yes, it does, but we'll need it for other-than-serverless. My understanding is the data stream lifecycle management isn't quite done yet. Once it is, then I think the next task would be to customize startup for severless to do whatever we need to do for the ILM-replacement thing. Does that sound right @kobelb ? |
Yup! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Verified that a datastream is created for 8.9 and that the exec log could read from both the data stream and pre-8.9 event log indices.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @pmuellr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security Solution integration test update LGTM! Thank you for this event-log upgrade @pmuellr!
Summary
resolves #62677
Changes event log from using indices, aliases, and ILM manually, to using data streams.
In general for the event log, we create a new set of indices / aliases / index template for each stack version. And then when we search over all event logs, we use a wildcard pattern to include all the existing versions. That continues with this PR. Just instead of creating indices / aliases for a new version, we create a data stream.
Existing event log indices / aliases are left alone, since the current way to search over existing event logs is with a wildcard. For instance,
.kibana-event-log-8.7.0
is the alias for 8.7.0 and.kibana-event-log-8.9.0
will be the data stream for 8.9.0. Searches over the event log are done using the index pattern.kibana-event-log-*
, so will search over all the aliases and data streams.Rolling back versions isn't a problem - the "new" resources created on the migration to a newer version, would only ever be referenced by search, if the deployment was rolled back to a previous verison. The existing indices / aliases / data streams for that version are left intact, the same structure they were in the release they were created in.
To test
The basic test is to ensure the event log is stil operational. You can do by checking the history tab of a running rule, which works off the event log.
To make sure we can still see old events from the older aliases / indices, you should actually start with an older version, create a rule and start it running, note the time the rule was started. Then migrate that deployment to this PR. Once Kibana comes up, check that the rule history still includes the run from the previous verison.
Checklist
Delete any items that are not applicable to this PR.