Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] AIOps: Adds field stats for metric and split fields #155177

Merged
merged 11 commits into from
Apr 20, 2023
Merged

[ML] AIOps: Adds field stats for metric and split fields #155177

merged 11 commits into from
Apr 20, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Apr 18, 2023 •
edited
Loading

Summary

Part of #151592

Adds unified field stats for metric and split field controls.

image

Checklist

@darnautov darnautov added release_note:enhancement :ml Team:ML Team label for ML (also use :ml) Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.8.0 labels Apr 18, 2023
@darnautov darnautov self-assigned this Apr 18, 2023
@darnautov darnautov mentioned this pull request Apr 18, 2023
Closed
6 tasks
@darnautov darnautov marked this pull request as ready for review April 18, 2023 15:44
@darnautov darnautov requested a review from a team as a code owner April 18, 2023 15:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov requested review from walterra and qn895 April 19, 2023 10:07
@qn895
Copy link
Member

qn895 commented Apr 19, 2023

Tested and LGTM 🎉

peteharverson
peteharverson reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, I also get the pointer cursor anywhere over the flyout which can lead to some odd interaction when clicking inside the flyout. Can you reproduce this?

x-pack/plugins/aiops/public/components/change_point_detection/fields_config.tsx Show resolved Hide resolved
@darnautov darnautov requested a review from peteharverson April 20, 2023 08:16
@darnautov darnautov requested a review from peteharverson April 20, 2023 10:26
peteharverson
peteharverson approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edits and LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
aiops 23 24 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 770.0KB 771.1KB +1.2KB
ml 3.4MB 3.4MB +74.0B
total +1.2KB
Unknown metric groups

API count

id before after diff
aiops 38 39 +1

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 20532c8 into elastic:main Apr 20, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 20, 2023
@darnautov darnautov deleted the ml-151592-unified-list-popover branch April 20, 2023 11:45
@szabosteve szabosteve changed the title [ML] AIOps: Add field stats for metric and split fields [ML] AIOps: Adds field stats for metric and split fields Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

@walterra walterra Awaiting requested review from walterra

@qn895 qn895 Awaiting requested review from qn895

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@darnautov @elasticmachine @qn895 @kibana-ci @walterra @peteharverson @kibanamachine