Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] PoC of the Detection Engine health API #157155

Merged
merged 11 commits into from
Jun 14, 2023
Merged

[Security Solution] PoC of the Detection Engine health API #157155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
05d1be8
Add placeholder route handlers for the API
banderror May 9, 2023
248edd9
Implement rule health endpoint: return rule and metadata
banderror May 10, 2023
7e3beab
Implement rule health endpoint: return stats and stats history
banderror May 11, 2023
a11db9d
Refactor and stub space and cluster health endpoints
banderror May 13, 2023
9baff50
Implement space health endpoint
banderror May 13, 2023
4d9e887
Refactor
banderror May 14, 2023
a7abff7
Fix CI
banderror May 26, 2023
831cc7f
Add comments
banderror May 26, 2023
3363aad
Add dev docs
banderror May 26, 2023
b2c0ad4
Addressing comments of @xcrzx
banderror Jun 13, 2023
e7856bb
Addressing comments of @pmuellr
banderror Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/kbn-securitysolution-io-ts-types/src/iso_date_string/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { Either } from 'fp-ts/lib/Either';
* Types the IsoDateString as:
* - A string that is an ISOString
*/
export type IsoDateString = t.TypeOf<typeof IsoDateString>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both IsoDateString and IsoDateStringC represent the same type, we can use either of them interchangeably, I wonder if is there any reason behind introducing this new export type IsoDateString = t.TypeOf<typeof IsoDateString>; ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WafaaNasr I think ideally we should delete IsoDateStringC and use IsoDateString as the type instead. TypeScript aliases allow to have a type and a constant with the same name -- this is useful when they represent conceptually the same thing, in this case, a schema and its corresponding type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But with the upcoming adoption of OpenAPI we might end up getting rid of all the io-ts schemas, so I didn't bother with refactoring further.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, Appreciate your explanation! thanks @banderror

export const IsoDateString = new t.Type<string, string, unknown>(
'IsoDateString',
t.string.is,
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/alerting/server/rules_client/lib/validate_rule_aggregation_fields.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ const ALLOW_FIELDS = [
'alert.attributes.snoozeSchedule.duration',
'alert.attributes.alertTypeId',
'alert.attributes.enabled',
'alert.attributes.params.*',
'alert.attributes.params.*', // TODO: https://github.com/elastic/kibana/issues/159602
'alert.attributes.params.immutable', // TODO: Remove after addressing https://github.com/elastic/kibana/issues/159602
];

const ALLOW_AGG_TYPES = ['terms', 'composite', 'nested', 'filter'];
Expand Down
Loading