-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Update CellActions field type to be FieldSpec #157243 #157834
Conversation
b38e323
to
933b0c2
Compare
@elasticmachine merge upstream |
0f3f773
to
4c11f06
Compare
@elasticmachine merge upstream |
x-pack/plugins/security_solution/public/common/components/cell_actions/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/common/components/cell_actions/index.tsx
Outdated
Show resolved
Hide resolved
1816160
to
996425c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks Pablo
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @machadoum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the threat-hunting-investigations team
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
3 similar comments
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
issue: #150347
Context
Some Actions need to access
FieldSpec
data, which is not present on theCellActions
API (subType
andisMapped
). So we are updating theCellActions
field
property to be compatible withFieldSpec
.Summary
This PR is the first step to fix #150347.
CellActions
to support an array of data objects, each containing field (FieldSpec
) and valueSecurityCellActions
component that accepts a field name and loadsFieldSpec
from the Dataview.Examples
Before:
After:
SecurityCellActions
will load the spec from the Dataview and provide it toCellActons
.CellActons
now also support an of fields instead of only one field. It will be useful when rendering cell actions for aggregated data like on the Entity Analytic page. But for now, the actions are not supporting multiple values, we need to rewrite them #159480.Next steps
We must refactor the Security Solution to get
FieldSpec
from theDataView
instead of using BrowserFields. Ideally, we have to do that for everyCellAction
call so the actions can access thesubType
property.Refactor the Security Solution CellActions calls to getFieldSpec
from theDataView
FieldSpec
from theDataView
subType
fromfieldSpec
isMapped
fromfieldSpec
Extra information
*** Previously we were mixing
esTypes
andkbnTypes
. For example, if theesType
is a keyword thekbnType
has to be astring
.Here you can check all possible ES and KBN types and here you can see the mapping between esType and kbnType
Checklist