Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics][Uptime][Ux] Update imports of hooks and components from Observability to Observability Shared #157866

Merged
merged 2 commits into from
May 16, 2023

Conversation

CoenWarmer
Copy link
Contributor

Resolves #157857

📝 Summary

This PR updates imports of hooks and components from Observability to Observability Shared.

It builds on the preparation work done in #157848.

More information on the progress in the epic.

✅ Acceptance criteria

  • Everything should work as before.

@CoenWarmer CoenWarmer requested a review from a team as a code owner May 16, 2023 12:12
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label May 16, 2023
@CoenWarmer CoenWarmer changed the title [Synthetics][Uptime][Ux] Update imports of hooks and components from Obs to Obs Shared [Synthetics][Uptime][Ux] Update imports of hooks and components from Observability to Observability Shared May 16, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB -6.0B
ux 164.8KB 164.9KB +22.0B
total +16.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew 116 clicks :)

Thank you for doing it !!

@CoenWarmer CoenWarmer merged commit 2802a7f into elastic:main May 16, 2023
@CoenWarmer CoenWarmer deleted the chore/update-synthetics-imports branch May 16, 2023 13:26
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 16, 2023
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics][UX] Update imports to Observability Shared
6 participants