Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra][Monitoring] Update imports from Observability to Observability Shared #157872

Merged
merged 8 commits into from
May 17, 2023
Merged

[Infra][Monitoring] Update imports from Observability to Observability Shared #157872

merged 8 commits into from
May 17, 2023

Conversation

CoenWarmer
Copy link
Contributor

Resolves #157852

📝 Summary

This PR updates imports of hooks and components from Observability to Observability Shared.

It builds on the preparation work done in #157848.

More information on the progress in the epic.

✅ Acceptance criteria

  • Everything should work as before.

@CoenWarmer CoenWarmer requested a review from a team as a code owner May 16, 2023 12:29
@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label May 16, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer force-pushed the chore/update-infra-imports branch from 2400782 to e16787a Compare May 16, 2023 12:39
@CoenWarmer CoenWarmer requested a review from a team as a code owner May 16, 2023 12:39
@CoenWarmer CoenWarmer changed the title [Infra] Update imports from Observability to Observability Shared [Infra][Monitoring] Update imports from Observability to Observability Shared May 16, 2023
alisonelizabeth
alisonelizabeth approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import change in x-pack/test/functional/apps/infra/tour.ts LGTM

@crespocarlos crespocarlos self-requested a review May 16, 2023 18:55
crespocarlos
crespocarlos reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Just left some minor nits to centralize imports from @kbn/observability-shared-plugin/public in a single import on some files

x-pack/plugins/infra/public/pages/logs/page_content.tsx Outdated Show resolved Hide resolved
x-pack/plugins/infra/public/pages/metrics/index.tsx Outdated Show resolved Hide resolved
...s/metrics/inventory_view/components/ml/anomaly_detection/anomalies_table/anomalies_table.tsx Outdated Show resolved Hide resolved
...ck/plugins/infra/public/pages/metrics/inventory_view/components/waffle/node_context_menu.tsx Outdated Show resolved Hide resolved
.../public/pages/logs/log_entry_categories/sections/top_categories/category_example_message.tsx Outdated Show resolved Hide resolved
CoenWarmer and others added 4 commits May 16, 2023 21:15
@CoenWarmer @crespocarlos
Update x-pack/plugins/infra/public/pages/logs/log_entry_categories/se…
7a1b1cc 
…ctions/top_categories/category_example_message.tsx

Co-authored-by: Carlos Crespo <[email protected]>
@CoenWarmer @crespocarlos
Update x-pack/plugins/infra/public/pages/logs/page_content.tsx
540babd 
Co-authored-by: Carlos Crespo <[email protected]>
@CoenWarmer @crespocarlos
Update x-pack/plugins/infra/public/pages/metrics/index.tsx
488891f 
Co-authored-by: Carlos Crespo <[email protected]>
@CoenWarmer @crespocarlos
Update x-pack/plugins/infra/public/pages/metrics/inventory_view/compo…
8ebe931 
…nents/ml/anomaly_detection/anomalies_table/anomalies_table.tsx

Co-authored-by: Carlos Crespo <[email protected]>
@CoenWarmer CoenWarmer enabled auto-merge (squash) May 16, 2023 19:23
@CoenWarmer CoenWarmer force-pushed the chore/update-infra-imports branch from 488da70 to 8d15e32 Compare May 16, 2023 19:45
@CoenWarmer CoenWarmer requested a review from crespocarlos May 16, 2023 19:45
mohamedhamed-ahmed
mohamedhamed-ahmed approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing the changes suggested

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #21 / spaces api without security get can access space_1 from within the default space "before all" hook for "should return 200 when referencing the default space implicitly"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.0MB 2.0MB -88.0B
monitoring 459.4KB 459.4KB -18.0B
total -106.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
monitoring 24.2KB 24.1KB -143.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 94c9491 into elastic:main May 17, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 17, 2023
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
@CoenWarmer @crespocarlos @jasonrhodes
[Infra][Monitoring] Update imports from Observability to Observabilit…
ca614ce 
…y Shared (#157872)

Co-authored-by: Carlos Crespo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@mohamedhamed-ahmed mohamedhamed-ahmed mohamedhamed-ahmed approved these changes

@crespocarlos crespocarlos Awaiting requested review from crespocarlos

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra] Update imports to Observability Shared
7 participants
@CoenWarmer @apmmachine @kibana-ci @crespocarlos @alisonelizabeth @mohamedhamed-ahmed @kibanamachine