-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Observability Plugin #157970
Reorganize Observability Plugin #157970
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
719fd18
to
e946043
Compare
4bb144a
to
0cba277
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM WFG !!
Obs ui and Uptime changes !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Onboarding changes LGTM. AFAICT the deleted files have already been relocated via #154716 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it!
@@ -792,16 +792,7 @@ packages/kbn-yarn-lock-validator @elastic/kibana-operations | |||
#CC# /x-pack/plugins/reporting/ @elastic/appex-sharedux | |||
#CC# /x-pack/plugins/serverless_security/ @elastic/appex-sharedux | |||
|
|||
### Observability Plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infra changes LGTM!
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Resolves #153308
📝 Summary
This PR cleans up the Observability app.
There are quite some changes, but the changes themselves are not controversial: they are mostly moving stuff around and throwing away stuff that was moved to other plugins or were no longer used anywhere.
It builds upon all the work done in this epic. If you want to understand the scope of the work, please take some time to check the PRs referenced in the epic.
In order to facilitate the review process I've done my best to categorize the changes in this PR into clearly labelled commits. So if you want to dig in, it might be helpful to review commit by commit.
🔬 Details
List of changes:
/components/shared
and/components/app
to/components
(commit)/pages/overview
(commit)/context
and/services
folders: moved related helpers closer together and removed unused ones (commit, commit)/x-pack/plugins/observability
(commit).✅ Checklist