Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Observability Plugin #157970

Merged
merged 19 commits into from
May 18, 2023

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented May 17, 2023

Resolves #153308

📝 Summary

This PR cleans up the Observability app.

There are quite some changes, but the changes themselves are not controversial: they are mostly moving stuff around and throwing away stuff that was moved to other plugins or were no longer used anywhere.

It builds upon all the work done in this epic. If you want to understand the scope of the work, please take some time to check the PRs referenced in the epic.

In order to facilitate the review process I've done my best to categorize the changes in this PR into clearly labelled commits. So if you want to dig in, it might be helpful to review commit by commit.

🔬 Details

List of changes:

  • Updated imports of components and hooks which were moved to Observability Shared (commit)
  • Move components from /components/shared and /components/app to /components (commit)
  • Consolidated all Overview components and helpers inside /pages/overview (commit)
  • Remove hooks, components and utilities which were either duplicated and moved to Observability Shared or Exploratory View, or just plain no longer used anywhere anymore (commit, commit)
  • Cleaned up /context and /services folders: moved related helpers closer together and removed unused ones (commit, commit)
  • Cleaned up plugin.ts and index.ts (commit)
  • Update CODEOWNERS file so Actionable Observability owns all folders and components in /x-pack/plugins/observability (commit).

✅ Checklist

  • Everything should work as before.

@CoenWarmer CoenWarmer requested review from a team as code owners May 17, 2023 09:48
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added the release_note:skip Skip the PR/issue when compiling release notes label May 17, 2023
@CoenWarmer CoenWarmer force-pushed the chore/cleanup-obs-app-for-real branch from 719fd18 to e946043 Compare May 17, 2023 10:18
@CoenWarmer CoenWarmer force-pushed the chore/cleanup-obs-app-for-real branch from 4bb144a to 0cba277 Compare May 17, 2023 11:18
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM WFG !!

Obs ui and Uptime changes !!

@CoenWarmer CoenWarmer enabled auto-merge (squash) May 17, 2023 14:59
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onboarding changes LGTM. AFAICT the deleted files have already been relocated via #154716 👍

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@@ -792,16 +792,7 @@ packages/kbn-yarn-lock-validator @elastic/kibana-operations
#CC# /x-pack/plugins/reporting/ @elastic/appex-sharedux
#CC# /x-pack/plugins/serverless_security/ @elastic/appex-sharedux

### Observability Plugins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@CoenWarmer CoenWarmer requested a review from a team as a code owner May 18, 2023 16:35
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra changes LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 410 308 -102

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 540 466 -74

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 972.3KB 906.5KB -65.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observability 25 14 -11

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 55.8KB 45.6KB -10.2KB
Unknown metric groups

API count

id before after diff
observability 546 472 -74

async chunk count

id before after diff
observability 14 7 -7

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
observability 33 24 -9
securitySolution 400 404 +4
total -3

miscellaneous assets size

id before after diff
observability 856.9KB 695.2KB -161.8KB

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
observability 37 28 -9
securitySolution 480 484 +4
total -3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit ab27caf into elastic:main May 18, 2023
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels May 18, 2023
delanni pushed a commit to delanni/kibana that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Observability folder structure
9 participants