[TaskManager] log health on interval with background_tasks only role #158890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves elastic#158870 For Kibana servers that only have node role `background_tasks`, log the task manager health report to the Kibana logs on an interval, currently every hour.
pmuellr
added
enhancement
|
Pinging @elastic/response-ops (Team:ResponseOps) |
pmuellr
added
the
release_note:skip
ymao1
approved these changes
Jun 5, 2023
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
pmuellr
added
v8.8.2
backport:prev-minor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Jun 6, 2023
…lastic#158890) resolves elastic#158870 ## Summary For Kibana servers that only have node role `background_tasks`, log the task manager health report to the Kibana logs on an interval, currently every hour. Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 837ef26) # Conflicts: # x-pack/plugins/task_manager/server/plugin.ts
pmuellr
added a commit
that referenced
this pull request
Jun 6, 2023
… role (#158890) (#159142) # Backport This will backport the following commits from `main` to `8.8`: - [[TaskManager] log health on interval with background_tasks only role (#158890)](#158890) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Patrick Mueller","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-06T12:42:40Z","message":"[TaskManager] log health on interval with background_tasks only role (#158890)\n\nresolves https://github.com/elastic/kibana/issues/158870\r\n\r\n## Summary\r\n\r\nFor Kibana servers that only have node role `background_tasks`, log the\r\ntask manager health report to the Kibana logs on an interval, currently\r\nevery hour.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"837ef26fb0cced40214b25f0f1f22a8a0d610fb2","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["enhancement","release_note:skip","Feature:Task Manager","Team:ResponseOps","backport:prev-minor","v8.9.0","v8.8.2"],"number":158890,"url":"https://github.com/elastic/kibana/pull/158890","mergeCommit":{"message":"[TaskManager] log health on interval with background_tasks only role (#158890)\n\nresolves https://github.com/elastic/kibana/issues/158870\r\n\r\n## Summary\r\n\r\nFor Kibana servers that only have node role `background_tasks`, log the\r\ntask manager health report to the Kibana logs on an interval, currently\r\nevery hour.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"837ef26fb0cced40214b25f0f1f22a8a0d610fb2"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158890","number":158890,"mergeCommit":{"message":"[TaskManager] log health on interval with background_tasks only role (#158890)\n\nresolves https://github.com/elastic/kibana/issues/158870\r\n\r\n## Summary\r\n\r\nFor Kibana servers that only have node role `background_tasks`, log the\r\ntask manager health report to the Kibana logs on an interval, currently\r\nevery hour.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"837ef26fb0cced40214b25f0f1f22a8a0d610fb2"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
|
This PR backport didn't make it into the latest BC for 8.8.1. Updating the labels. |
Just for reference, we didn't intend to put it in 8.8.1 (though would have been nice!) - I did have a label on it for 8.8.1, before 8.8.1 got pulled in, that I changed to 8.8.2, then kibanamachine added 8.8.1 after the backport. I assume this was a timing race between the merge and the FF, which I'm guessing happened the same day. It's been a while, but learned my lesson on merging backports on a FF day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #158870
Summary
For Kibana servers that only have node role
background_tasks, log the task manager health report to the Kibana logs on an interval, currently every hour.