-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Unskip ML accessibility tests #160204
Conversation
@peteharverson so green in CI but I see flaky test errors on https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2441 and they all look like for links should be distinguishable from surrounding text. Do you know whats happening? cc @1Copenut ML team fixed the links bug #154294. Could you please take a look? Thanks very much |
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Pinging @elastic/ml-ui (:ml) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @bhavyarm |
@bhavyarm another page is failing with the All the transform test failures seem to have the same error. I'm guessing there is something wrong with the test structure here. I've also logged a separate issue for these errors - #160382 We will aim to get these fixed for |
Great. Thanks very much @peteharverson. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@bhavyarm I think this PR can be closed as @darnautov has unskipped the ML accessibility tests in #160608 and the transform ones in #160649. |
Ok awesome. Thanks @peteharverson |
Unskipping ML a11y tests as ml a11y bugs - #153592 & #153596 & #154294 are fixed