Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] fix merging the existing saved object with the new one instead of replacing #160260

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[Lens] fix merging the existing saved object with the new one instead of replacing #160260

merged 1 commit into from
Jun 22, 2023

Conversation

mbondyra
Copy link
Contributor

Fixes #160116

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting v8.9.0 labels Jun 22, 2023
@mbondyra mbondyra marked this pull request as ready for review June 22, 2023 11:36
@mbondyra mbondyra requested a review from a team as a code owner June 22, 2023 11:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 416 420 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 497 501 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, I tested it with various scenarios and checking the SOs and it works as expected :)

@mbondyra mbondyra merged commit 3fc1e68 into elastic:main Jun 22, 2023
@mbondyra mbondyra deleted the lens/fix_cm branch June 22, 2023 13:01
@stratoula stratoula added v8.10.0 and removed v8.9.0 labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Datasource dimensions are not cleared properly
4 participants
@mbondyra @elasticmachine @kibana-ci @stratoula