[SecuritySolutions] Update CellActions to support all types used by Discover

[machadoum]

Original issue: #144943

Summary

• Update CellActions value to be Serializable.
• Update Default Actions and SecuritySolution Actions to allowlist the supported Kibana types.
• Add an extra check to Action's execute to ensure the field value is compatible.

How to test it?

• Open Discover and create a saved search with many different field types
• Go to Security Solutions dashboards
• Create a new dashboard and import the saved search
• Test the created dashboard inside Security Solutions

Checklist

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios

[machadoum]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[machadoum]

@elasticmachine merge upstream

[machadoum]

@elasticmachine merge upstream

[semd]

Awesome! This is not a very rewarding job, but this standarization was very necessary. It will open the cell-actions framework to support any use case.
Thanks Pablo! 👏

[semd]

NIT:

Suggested change

	value: Array<string | number | boolean>
	value: SerializableArray

?

[machadoum]

This function only receives Array<string | number | boolean> because we call it after filtering out other values. We could use a more generic type like SerializableArray but the extra types won't be used. Also, If we receive a SerializableArray the type guard would have to be expanded to tring[] | number[] | boolean[] | null[] | undefined[] | SerializableArray | SerializableRecord[] . I am not sure if it is worth it.

[semd]

Is the value.every(isNonNullablePrimitiveValue) needed? The value parameter is already NonNullableSerializable[]?

[machadoum]

isNonNullablePrimitiveValue is required to drop non-primitive values like SerializableArray and SerializableRecord.
The confusion is due to the bad naming. isNonNullablePrimitiveValue checks if the value is string, number, or boolean, which are primitive and not nullable. I will inline the function to avoid naming it. 😆

[davismcphee]

Great job on these changes! This is a big improvement for cell actions and makes it applicable to a much wider range of use cases 🙌

I tested locally with a custom Security dashboard including less common scenarios like no timestamp, flattened fields, and field conflicts, and everything seemed to work as expected. LGTM 👍

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 049ed0f

Failed CI Steps

• Security Solution Tests #1

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
discover	596	597	+1
securitySolution	4233	4235	+2
total			+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
discover	530.2KB	530.4KB	+277.0B
securitySolution	11.0MB	11.0MB	+4.1KB
total			+4.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
@kbn/cell-actions	2	3	+1

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	14	16	+2
securitySolution	413	417	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	15	17	+2
securitySolution	492	496	+4
total			+6

History

• 💔 Build #139321 failed f8ecd7a
• 💛 Build #139115 was flaky 879dfd6
• 💛 Build #139042 was flaky 3b359fe
• 💔 Build #138797 failed f5f0ddfe22b51e7c2c193388450f06bcfb769dde
• 💔 Build #138506 failed 0316383
• 💔 Build #138463 failed a07b6df

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

[lgestc]

lgtm