Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.9] [Security Solution] Fix rule monitoring dashboard (#160316) #160617

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.9:

Questions ?

Please refer to the Backport tool documentation

**Epic:** elastic/security-team#6032
(internal)
**Related to:** elastic#159875

## Summary

In this PR we:

- add a text block to the dashboard itself with helpful info about it
- fix the 4 tables at the bottom of the dashboard
- add unit tests for the dashboard's source `.json` files

## Text block

<img width="1792" alt="Screenshot 2023-06-22 at 20 15 30"
src="https://github.com/elastic/kibana/assets/7359339/55d267b7-7c39-4cdf-a917-fd17e9231a59">

## Tables

There were two issues with the tables:

1. When having the same prebuilt rules installed in two or more Kibana
spaces, sorting in a table could break if the table rendered two
different rules with the same name. It has been fixed by making the rule
ID the first field in the table and making a few minor tweaks. Thanks to
@maximpn for noticing the bug.
2. Widths of the columns were off in some cases.

The fixed tables look like that:

<img width="1775" alt="Screenshot 2023-06-22 at 19 52 13"
src="https://github.com/elastic/kibana/assets/7359339/53475848-3238-4866-af70-080b8acd1f9e">

## Full comparison

| **BEFORE** | **AFTER** |
|:------------:|:-----------:|
| ![Dashboard
BEFORE](https://github.com/elastic/kibana/assets/7359339/755cc044-5613-4c78-b89f-2a9734ded76d)
| ![Dashboard
AFTER](https://github.com/elastic/kibana/assets/7359339/38ac67f7-b9f8-4ddf-833f-e8e98eb2bfb1)
|

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
    - elastic/security-docs#3478

(cherry picked from commit f622809)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #3 / Detection response view Open in timeline "after each" hook for "opens timeline with correct query count for open alerts by rule table"
  • [job] [logs] Investigations - Security Solution Tests #2 / Detection response view Open in timeline "after each" hook for "opens timeline with correct query count for open alerts by rule table"
  • [job] [logs] Security Solution Tests #3 / Detection response view Open in timeline opens timeline with correct query count for open alerts by rule table
  • [job] [logs] Investigations - Security Solution Tests #2 / Detection response view Open in timeline opens timeline with correct query count for open alerts by rule table
  • [job] [logs] Security Solution Tests #6 / Detections : Page Filters Alert list is updated when the alerts are updated
  • [job] [logs] Investigations - Security Solution Tests #2 / Detections : Page Filters Alert list is updated when the alerts are updated
  • [job] [logs] Security Solution Tests #6 / Detections : Page Filters Impact of inputs should recover from invalide kql Query result
  • [job] [logs] Investigations - Security Solution Tests #2 / Detections : Page Filters Impact of inputs should recover from invalide kql Query result
  • [job] [logs] Security Solution Tests #1 / Prebuilt rules Alerts rules, prebuilt rules "before each" hook for "Loads prebuilt rules"

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 13 15 +2
securitySolution 415 419 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 14 16 +2
securitySolution 496 500 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @banderror

@kibanamachine kibanamachine merged commit 9b77b6d into elastic:8.9 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants