Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Detection Response][Cypress] Reshuffle bulk action cypress tests #161900

Merged
merged 5 commits into from
Jul 21, 2023
Merged

[Detection Response][Cypress] Reshuffle bulk action cypress tests #161900

merged 5 commits into from
Jul 21, 2023

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Jul 13, 2023 •
edited
Loading

Summary

A very small first piece to address #153645

  • Starts adding new folder structure in cypress tests detections_response/rules_management
  • Adds detections_response/rules_management/bulk_actions
  • Reshuffled screens and tasks to now also have a corresponding screens/rules_bulk_actions.ts and tasks/rules_bulk_actions.ts
  • We chatted and decided to try to organize tests by subdomains rather than by teams. Anticipated upcoming changes will add something like:
  • detections_response/rules_management
    • /bulk_actions.ts
    • /rules_table.ts
  • detections_response/prebuilt_rules
  • detections_response/rule_creation
  • detections_response/rule_details
  • detections_response/rule_edit
  • detections_response/exceptions
    • /shared_exception_lists
    • /alerts_table
    • /alerts_details
    • /rule_details

@yctercero
reshuffling detection and response cypress tests in anticipation of c…
74f2dc9 
…reating configs for running our tests separately
@yctercero yctercero requested review from a team as code owners July 13, 2023 18:01
@yctercero yctercero requested a review from jpdjere July 13, 2023 18:01
@yctercero yctercero self-assigned this Jul 13, 2023
@yctercero yctercero added v8.10.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detection Engine Security Solution Detection Engine Area labels Jul 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

banderror
banderror approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's 🚀

e40pud
e40pud approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

Running in flakey test runner - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2652

@banderror
Copy link
Contributor

@yctercero 👋 I picked up this PR and resolved conflicts in it with the main branch. I'm going to try to fix failing tests in it, but if I'm not able to do it relatively quickly I'll probably start restructuring tests from scratch in a separate PR.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@banderror
Copy link
Contributor

It's passed CI 🎉
Running https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2691

@banderror banderror merged commit e54cf60 into elastic:main Jul 21, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 21, 2023
@banderror banderror mentioned this pull request Jul 25, 2023
Merged
banderror added a commit that referenced this pull request Jul 25, 2023
@banderror
[Security Solution] Restructure Cypress tests under `security_solutio…
4087316 
…n/cypress/e2e/detection_rules` folder (#162373)

**Epic:** #153633
**Partially addresses:** #153645

## Summary

This PR builds upon #161900 and
moves tests located in the `e2e/detection_rules` folder into
`e2e/detection_response` and splits them into multiple sub-folders
according to the Detection Engine subdomains we have. It also updates
the CODEOWNERS file accordingly.

<img width="451" alt="Screenshot 2023-07-25 at 21 03 08"
src="https://github.com/elastic/kibana/assets/7359339/fb6052c9-3c5d-4547-98f1-61f44b9f7187">

## Details

Specifically, changes in this PR include:

- The `e2e/detections_response` folder was renamed to
`e2e/detection_response`.
- The `e2e/detections_response/bulk_actions` folder became
`e2e/detection_response/rule_management/rule_actions/bulk_actions`.
- Cypress tests for rule types (which actually test rule creation for
different rule types) were moved to
`e2e/detection_response/rule_creation`.
- The CODEOWNERS file was updated.

Things not addressed in this PR:

- No ownership was assigned for `e2e/detection_response/rule_actions`.
Will need to figure this out with @yctercero.
- No restructuring was done for `security_solution/cypress/screens` and
`security_solution/cypress/tasks`. Will be done in follow-up PRs.
- No refactoring was done for the tests themselves. Some of this work is
also upcoming.

The full file structure of the `detection_response` tests looks like
this:

<img width="452" alt="Screenshot 2023-07-25 at 21 03 44"
src="https://github.com/elastic/kibana/assets/7359339/2b89c6d2-9f2d-4cf6-914f-a71c3fa93595">
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@yctercero @kibanamachine @banderror
[Detection Response][Cypress] Reshuffle bulk action cypress tests (el…
7d75819 
…astic#161900)

## Summary

A very small first piece to address
elastic#153645

- Starts adding new folder structure in cypress tests
`detections_response/rules_management`
- Adds `detections_response/rules_management/bulk_actions`
- Reshuffled screens and tasks to now also have a corresponding
`screens/rules_bulk_actions.ts` and `tasks/rules_bulk_actions.ts`
- We chatted and decided to try to organize tests by subdomains rather
than by teams. Anticipated upcoming changes will add something like:
- `detections_response/rules_management`
    - `/bulk_actions.ts`
    - `/rules_table.ts`
- `detections_response/prebuilt_rules`
- `detections_response/rule_creation`
- `detections_response/rule_details`
- `detections_response/rule_edit`
- `detections_response/exceptions`
    -  `/shared_exception_lists` 
    - `/alerts_table`
    - `/alerts_details`
    - `/rule_details`

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Georgii Gorbachev <[email protected]>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@banderror
[Security Solution] Restructure Cypress tests under `security_solutio…
212b154 
…n/cypress/e2e/detection_rules` folder (elastic#162373)

**Epic:** elastic#153633
**Partially addresses:** elastic#153645

## Summary

This PR builds upon elastic#161900 and
moves tests located in the `e2e/detection_rules` folder into
`e2e/detection_response` and splits them into multiple sub-folders
according to the Detection Engine subdomains we have. It also updates
the CODEOWNERS file accordingly.

<img width="451" alt="Screenshot 2023-07-25 at 21 03 08"
src="https://github.com/elastic/kibana/assets/7359339/fb6052c9-3c5d-4547-98f1-61f44b9f7187">

## Details

Specifically, changes in this PR include:

- The `e2e/detections_response` folder was renamed to
`e2e/detection_response`.
- The `e2e/detections_response/bulk_actions` folder became
`e2e/detection_response/rule_management/rule_actions/bulk_actions`.
- Cypress tests for rule types (which actually test rule creation for
different rule types) were moved to
`e2e/detection_response/rule_creation`.
- The CODEOWNERS file was updated.

Things not addressed in this PR:

- No ownership was assigned for `e2e/detection_response/rule_actions`.
Will need to figure this out with @yctercero.
- No restructuring was done for `security_solution/cypress/screens` and
`security_solution/cypress/tasks`. Will be done in follow-up PRs.
- No refactoring was done for the tests themselves. Some of this work is
also upcoming.

The full file structure of the `detection_response` tests looks like
this:

<img width="452" alt="Screenshot 2023-07-25 at 21 03 44"
src="https://github.com/elastic/kibana/assets/7359339/2b89c6d2-9f2d-4cf6-914f-a71c3fa93595">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banderror banderror banderror approved these changes

@jpdjere jpdjere jpdjere approved these changes

@e40pud e40pud e40pud approved these changes

Assignees

@yctercero yctercero

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detection Rule Management Security Detection Rule Management Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yctercero @elasticmachine @banderror @kibana-ci @e40pud @jpdjere @kibanamachine