Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Flaky test] Fix double ftr test flakiness #162990

Merged
merged 9 commits into from
Aug 9, 2023
Merged

[Security Solution] [Flaky test] Fix double ftr test flakiness #162990

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
22a1b25
add logger to see on ci
WafaaNasr Aug 2, 2023
e5ec441
add loggers to debug the values
WafaaNasr Aug 3, 2023
c4f6a6e
try warning in logs
WafaaNasr Aug 3, 2023
fa4a7d5
only log.error gets captured in ci
WafaaNasr Aug 3, 2023
c80b36b
increase number of alerts to wait for to 3 since we are expecting 3 a…
WafaaNasr Aug 8, 2023
0adfdbd
Merge branch 'main' of https://github.com/elastic/kibana into fix-dou…
WafaaNasr Aug 8, 2023
11fba56
remove logs
WafaaNasr Aug 9, 2023
585bfc8
Merge branch 'main' into fix-doubleftr-flakiness
WafaaNasr Aug 9, 2023
a3baa11
Merge branch 'main' into fix-doubleftr-flakiness
WafaaNasr Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...ngine_api_integration/security_and_spaces/group7/exception_operators_data_types/double.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ export default ({ getService }: FtrProviderContext) => {
const log = getService('log');
const es = getService('es');

// Failing: See https://github.com/elastic/kibana/issues/155122
describe.skip('Rule exception operators for data type double', () => {
describe('Rule exception operators for data type double', () => {
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/rule_exceptions/double');
await esArchiver.load('x-pack/test/functional/es_archives/rule_exceptions/double_as_string');
Expand Down Expand Up @@ -490,7 +489,6 @@ export default ({ getService }: FtrProviderContext) => {
expect(hits).to.eql([]);
});
});

describe('working against string values in the data set', () => {
it('will return 3 results if we have a list that includes 1 double', async () => {
await importFile(supertest, log, 'double', ['1.0'], 'list_items.txt');
Expand All @@ -509,7 +507,7 @@ export default ({ getService }: FtrProviderContext) => {
],
]);
await waitForRuleSuccess({ supertest, log, id });
await waitForSignalsToBePresent(supertest, log, 1, [id]);
await waitForSignalsToBePresent(supertest, log, 3, [id]);
const signalsOpen = await getSignalsById(supertest, log, id);
const hits = signalsOpen.hits.hits.map((hit) => hit._source?.double).sort();
expect(hits).to.eql(['1.1', '1.2', '1.3']);
Expand Down