[Cloud Security][CIS GCP] Add Agent flyout updates for CIS GCP #163910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
animehart
changed the title
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
hop-dev
approved these changes
Aug 23, 2023
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
animehart
added
backport:prev-minor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 24, 2023
…ic#163910) ## Summary This PR is for changing how Cloud Shell flyout looks when adding agent. Previously it shows tabs for other installation method, now it no longer shows that (similar to what we have we Cloud Formation) We also updated the steps and command to copy. <img width="836" alt="Screenshot 2023-08-22 at 10 28 05 AM" src="https://github.com/elastic/kibana/assets/8703149/f312431a-e0fa-470e-896b-04324a160fdb"> <img width="857" alt="Screenshot 2023-08-22 at 10 29 12 AM" src="https://github.com/elastic/kibana/assets/8703149/51b33fcd-11b9-4691-946c-83cab6fd4f5a"> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit c66f58a)
kibanamachine
added a commit
that referenced
this pull request
Aug 29, 2023
…#163910) (#164771) # Backport This will backport the following commits from `main` to `8.10`: - [[Cloud Security][CIS GCP] Add Agent flyout updates for CIS GCP (#163910)](#163910) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rickyanto Ang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-24T18:38:39Z","message":"[Cloud Security][CIS GCP] Add Agent flyout updates for CIS GCP (#163910)\n\n## Summary\r\nThis PR is for changing how Cloud Shell flyout looks when adding agent.\r\nPreviously it shows tabs for other installation method, now it no longer\r\nshows that (similar to what we have we Cloud Formation)\r\nWe also updated the steps and command to copy.\r\n<img width=\"836\" alt=\"Screenshot 2023-08-22 at 10 28 05 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/f312431a-e0fa-470e-896b-04324a160fdb\">\r\n<img width=\"857\" alt=\"Screenshot 2023-08-22 at 10 29 12 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/51b33fcd-11b9-4691-946c-83cab6fd4f5a\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c66f58ae0cbbb1c35a8f023f5507e60aff94dda4","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","Team:Cloud Security","backport:prev-minor","v8.10.0","v8.11.0"],"number":163910,"url":"https://github.com/elastic/kibana/pull/163910","mergeCommit":{"message":"[Cloud Security][CIS GCP] Add Agent flyout updates for CIS GCP (#163910)\n\n## Summary\r\nThis PR is for changing how Cloud Shell flyout looks when adding agent.\r\nPreviously it shows tabs for other installation method, now it no longer\r\nshows that (similar to what we have we Cloud Formation)\r\nWe also updated the steps and command to copy.\r\n<img width=\"836\" alt=\"Screenshot 2023-08-22 at 10 28 05 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/f312431a-e0fa-470e-896b-04324a160fdb\">\r\n<img width=\"857\" alt=\"Screenshot 2023-08-22 at 10 29 12 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/51b33fcd-11b9-4691-946c-83cab6fd4f5a\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c66f58ae0cbbb1c35a8f023f5507e60aff94dda4"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163910","number":163910,"mergeCommit":{"message":"[Cloud Security][CIS GCP] Add Agent flyout updates for CIS GCP (#163910)\n\n## Summary\r\nThis PR is for changing how Cloud Shell flyout looks when adding agent.\r\nPreviously it shows tabs for other installation method, now it no longer\r\nshows that (similar to what we have we Cloud Formation)\r\nWe also updated the steps and command to copy.\r\n<img width=\"836\" alt=\"Screenshot 2023-08-22 at 10 28 05 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/f312431a-e0fa-470e-896b-04324a160fdb\">\r\n<img width=\"857\" alt=\"Screenshot 2023-08-22 at 10 29 12 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/8703149/51b33fcd-11b9-4691-946c-83cab6fd4f5a\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c66f58ae0cbbb1c35a8f023f5507e60aff94dda4"}}]}] BACKPORT--> Co-authored-by: Rickyanto Ang <[email protected]> Co-authored-by: Paulo Henrique <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for changing how Cloud Shell flyout looks when adding agent. Previously it shows tabs for other installation method, now it no longer shows that (similar to what we have we Cloud Formation)
We also updated the steps and command to copy.